Preserve explicit register names in inline asm diagnostics - #160068
Open
qaijuang wants to merge 2 commits into
Open
Preserve explicit register names in inline asm diagnostics#160068qaijuang wants to merge 2 commits into
qaijuang wants to merge 2 commits into
Conversation
rustbot
added
S-waiting-on-author
Collaborator
|
|
qaijuang
marked this pull request as ready for review
July 28, 2026 13:17
rustbot
added
the
S-waiting-on-review
Collaborator
|
cc @rust-lang/clippy |
rustbot
removed
the
S-waiting-on-author
qaijuang
force-pushed
the
fix-asm-register-alias-diagnostic
branch
from
July 28, 2026 13:47
77c0f58 to
d33866e
Compare
| _ => None, | ||
| }; | ||
| let reg_str = |idx| -> &str { | ||
| // HIR asm doesn't preserve the original alias string of the explicit register, |
Member
There was a problem hiding this comment.
Is there a reason it shouldn't, instead of this scheme of re-adding it in metadata?
Contributor
Author
There was a problem hiding this comment.
I don't see or find any reason why it shouldn't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds diagnostic-only metadata directly to each register-bearing HIR operand, and replaces #117912 AST lookup with the new HIR metadata.
r? @workingjubilee
Fixes #159409