Rollup of 6 pull requests by JonathanBrouwer · Pull Request #160072 · rust-lang/rust

JonathanBrouwer · 2026-07-28T13:04:42Z

Successful merges:

Avoid stale closure recovery state across statements #160008 (Avoid stale closure recovery state across statements)
Add regression test for #132767 #160027 (Add regression test for [ICE]: maybe try to call try_normalize_erasing_regions instead #132767)
Update browser-ui-test version to 0.25.0 #160030 (Update browser-ui-test version to 0.25.0)
Improve consistency of attribute error messages (part 2) #160046 (Improve consistency of attribute error messages (part 2))
Fix associated function suggestion for generic ADTs #160056 (Fix associated function suggestion for generic ADTs)
Update Rust crate tracing-subscriber to v0.3.23 [SECURITY] #160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY])

Coercing the fn item `bar` to a fn pointer while `Foo::value` holds the associated-type projection `<<T as Func>::Ret as Id>::Assoc` used to ICE during normalization ("maybe try to call `try_normalize_erasing_regions` instead"). It now reports the ordinary `u32: Id` trait-bound error instead of crashing.

The carets should ideally point to the path, not the entire attribute, but that's hard to achieve with the current code structure.

The carets already point to just the attribute path, which is what we want.

…, r=mati865 Avoid stale closure recovery state across statements Fixes rust-lang#159989 `current_closure` was cleared when starting a new expression through `parse_expr`, but statement expressions call `parse_expr_res` directly. This allowed closure recovery state from one statement to remain active while parsing the next statement. This pr clears `current_closure` when entering `parse_stmt_without_recovery`, matching the behavior of `parse_expr`. https://github.com/rust-lang/rust/blob/da2697d1d842f4faf83083115aab396f82829a3a/compiler/rustc_parse/src/parser/expr.rs#L55-L56 https://github.com/rust-lang/rust/blob/da2697d1d842f4faf83083115aab396f82829a3a/compiler/rustc_parse/src/parser/expr.rs#L63-L64

Add regression test for rust-lang#132767 Closes rust-lang#132767. Coercing a fn item to a fn pointer with an associated type projection used to ICE during normalization. now errors with E0277.

…est, r=GuillaumeGomez Update `browser-ui-test` version to `0.25.0` With this new version we should be able to finally add a regression test for [the "code copy" ](rust-lang#158137). r? ghost

@estebank

Improve consistency of attribute error messages (part 2) A sequel to rust-lang#159755. r? @estebank

@estebank

…-fn-turbofish, r=estebank Fix associated function suggestion for generic ADTs Fixes rust-lang#159813 r? @estebank

…g-subscriber-vulnerability, r=jieyouxu Update Rust crate tracing-subscriber to v0.3.23 [SECURITY] This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tracing-subscriber](https://tokio.rs) ([source](https://redirect.github.com/tokio-rs/tracing)) | dependencies | patch | `0.3.22` → `0.3.23` | | [tracing-subscriber](https://tokio.rs) ([source](https://redirect.github.com/tokio-rs/tracing)) | dev-dependencies | patch | `0.3.22` → `0.3.23` | --- ### Tracing logging user input may result in poisoning logs with ANSI escape sequences [CVE-2025-58160](https://nvd.nist.gov/vuln/detail/CVE-2025-58160) / [GHSA-xwfj-jgwm-7wp5](https://redirect.github.com/advisories/GHSA-xwfj-jgwm-7wp5) <details> <summary>More information</summary> #### Details ##### Impact Previous versions of tracing-subscriber were vulnerable to ANSI escape sequence injection attacks. Untrusted user input containing ANSI escape sequences could be injected into terminal output when logged, potentially allowing attackers to: - Manipulate terminal title bars - Clear screens or modify terminal display - Potentially mislead users through terminal manipulation In isolation, impact is minimal, however security issues have been found in terminal emulators that enabled an attacker to use ANSI escape sequences via logs to exploit vulnerabilities in the terminal emulator. ##### Patches `tracing-subscriber` version 0.3.20 fixes this vulnerability by escaping ANSI control characters in when writing events to destinations that may be printed to the terminal. ##### Workarounds Avoid printing logs to terminal emulators without escaping ANSI control sequences. ##### References https://www.packetlabs.net/posts/weaponizing-ansi-escape-sequences/ ##### Acknowledgments We would like to thank [zefr0x](http://github.com/zefr0x) who responsibly reported the issue at `security@tokio.rs`. If you believe you have found a security vulnerability in any tokio-rs project, please email us at `security@tokio.rs`. #### Severity - CVSS Score: 2.3 / 10 (Low) - Vector String: `CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:P/VC:N/VI:L/VA:N/SC:N/SI:N/SA:N` #### References - [https://github.com/tokio-rs/tracing/security/advisories/GHSA-xwfj-jgwm-7wp5](https://redirect.github.com/tokio-rs/tracing/security/advisories/GHSA-xwfj-jgwm-7wp5) - [https://nvd.nist.gov/vuln/detail/CVE-2025-58160](https://nvd.nist.gov/vuln/detail/CVE-2025-58160) - [https://rustsec.org/advisories/RUSTSEC-2025-0055.html](https://rustsec.org/advisories/RUSTSEC-2025-0055.html) - [https://github.com/advisories/GHSA-xwfj-jgwm-7wp5](https://redirect.github.com/advisories/GHSA-xwfj-jgwm-7wp5) This data is provided by the [GitHub Advisory Database](https://redirect.github.com/advisories/GHSA-xwfj-jgwm-7wp5) ([CC-BY 4.0](https://redirect.github.com/github/advisory-database/blob/main/LICENSE.md)). </details> --- ### Release Notes <details> <summary>tokio-rs/tracing (tracing-subscriber)</summary> ### [`v0.3.23`](https://redirect.github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.23): tracing-subscriber 0.3.23 [Compare Source](https://redirect.github.com/tokio-rs/tracing/compare/tracing-subscriber-0.3.22...tracing-subscriber-0.3.23) ##### Fixed - Allow ansi sanitization to be disabled ([#&rust-lang#8203;3484]) [#&rust-lang#8203;3484]: https://redirect.github.com/tokio-rs/tracing/pull/3484 </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/rust-lang/rust).

JonathanBrouwer · 2026-07-28T13:05:09Z

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-*

rust-bors · 2026-07-28T13:05:11Z

📌 Commit 15142d2 has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-07-28T13:05:17Z

⌛ Trying commit 15142d2 with merge 8d65e0d…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/30361860272

Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-*

JonathanBrouwer · 2026-07-28T14:31:00Z

@bors try cancel

rust-bors · 2026-07-28T14:31:04Z

This pull request was unapproved due to being closed.

rust-bors · 2026-07-28T14:31:06Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/30361860272

TaKO8Ki and others added 20 commits July 27, 2026 20:19

add regression test for stale closure recovery state

7f8e276

reset closure recovery state before parsing a statement

da2697d

Update browser-ui-test version to 0.25.0

4ab575d

Improve consistency of proc macro attribute error messages

51a9794

Improve consistency of rustc_abi attribute error messages

c9be59d

Improve consistency of rustc_const_stable attribute error messages

02df958

Improve consistency of diagnostic::on_const attribute error messages

909079f

Improve consistency of test/bench attribute error messages

6c97237

The carets should ideally point to the path, not the entire attribute, but that's hard to achieve with the current code structure.

Improve consistency of unsafe attribute error messages

8704b63

The carets already point to just the attribute path, which is what we want.

Add regression test for generic associated function suggestions

8bfa429

Use value syntax for associated function suggestions

c9dbe2b

Add missing "clipboard-read" permission

1d32220

Update Rust crate tracing-subscriber to v0.3.23 [SECURITY]

32246e5

Rollup merge of rust-lang#160027 - zakrad:regr-test-132767, r=chenyukang

de5ee6b

Add regression test for rust-lang#132767 Closes rust-lang#132767. Coercing a fn item to a fn pointer with an associated type projection used to ICE during normalization. now errors with E0277.

Rollup merge of rust-lang#160030 - GuillaumeGomez:update-browser-ui-t…

de1d570

…est, r=GuillaumeGomez Update `browser-ui-test` version to `0.25.0` With this new version we should be able to finally add a regression test for [the "code copy" ](rust-lang#158137). r? ghost

Rollup merge of rust-lang#160046 - nnethercote:attr-errors-2, r=estebank

93bd4b1

Improve consistency of attribute error messages (part 2) A sequel to rust-lang#159755. r? @estebank

Rollup merge of rust-lang#160056 - chenyukang:yukang-fix-159813-assoc…

e12f273

…-fn-turbofish, r=estebank Fix associated function suggestion for generic ADTs Fixes rust-lang#159813 r? @estebank

rust-bors Bot added the rollup A PR which is a rollup label Jul 28, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2026

JonathanBrouwer closed this Jul 28, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 6 pull requests - #160072

Rollup of 6 pull requests#160072
JonathanBrouwer wants to merge 20 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-c2auAd2

JonathanBrouwer commented Jul 28, 2026 •

edited by rustbot

Loading

Uh oh!

JonathanBrouwer commented Jul 28, 2026

Uh oh!

rust-bors Bot commented Jul 28, 2026

Uh oh!

rust-bors Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

JonathanBrouwer commented Jul 28, 2026

Uh oh!

rust-bors Bot commented Jul 28, 2026

Uh oh!

rust-bors Bot commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Jul 28, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jul 28, 2026

Uh oh!

rust-bors Bot commented Jul 28, 2026

Uh oh!

rust-bors Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jul 28, 2026

Uh oh!

rust-bors Bot commented Jul 28, 2026

Uh oh!

rust-bors Bot commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

JonathanBrouwer commented Jul 28, 2026 •

edited by rustbot

Loading

rust-bors Bot commented Jul 28, 2026 •

edited

Loading