style(edition): migrate the codebase to the 2024 Style Edition#4190
Merged
rami3l merged 2 commits intorust-lang:masterfrom Feb 21, 2025
Merged
style(edition): migrate the codebase to the 2024 Style Edition#4190rami3l merged 2 commits intorust-lang:masterfrom
rami3l merged 2 commits intorust-lang:masterfrom
Conversation
f285137 to
9b416ed
Compare
f0e39df to
a4a0fb7
Compare
a4a0fb7 to
acd75d1
Compare
ChrisDenton
approved these changes
Feb 20, 2025
Member
ChrisDenton
left a comment
There was a problem hiding this comment.
Seems fine. Though did something about maximum line length change? In any case using the new style seems like a good idea.
Member
Author
|
@ChrisDenton I believe what's really happening is that |
Member
|
Ah that makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first part of rustup's migration to Rust 2024, which contains style-related changes only. Notably, macro invocations are now correctly formatted by
rustfmt.A second PR will follow shortly once this one gets merged, which will perform a semi-auto migration based on #4061's plan:
PS: The newly-added
rustfmtconfig is here for migration purposes. It should be deleted by the end of the second PR.PPS: The CI should pass once the 2024 Edition lands in stable in a few hours.