feat(cli/rustup-mode): add "Exit status" section to rustup check --help
#4696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
reviewed
Jan 31, 2026
rami3l
reviewed
Jan 31, 2026
Member
rami3l
left a comment
rami3l
left a comment
There was a problem hiding this comment.
Please update the test snapshots at the same time with SNAPSHOTS=overwrite so that the CI turns green again. Many thanks for your help!
rami3l
approved these changes
Feb 1, 2026
Member
There was a problem hiding this comment.
@appleGun22 LGTM!
Please change the commit message and the PR title to better reflect what this patch is doing: clearly it's not about adding --help since it's already been implemented. Rather, you are adding a section about exit codes to it.
Apart from that, just squash all commits into one and we are good to go.
Many thanks again :)
3 tasks
djc
approved these changes
Feb 2, 2026
rami3l
previously requested changes
Feb 2, 2026
rami3l
changed the title
--help option for rustup check commandrustup check --help
Contributor
Author
|
@rami3l I see that you already squashed them together, but still thank you for the guidance, it was my first PR to rustup :) |
djc
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation to #4694.