fix(cli/proxy-mode): stop enforcing quiet: true#4762
Merged
rami3l merged 1 commit intorust-lang:mainfrom Mar 20, 2026
Merged
Conversation
djc
approved these changes
Mar 20, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4761.
Not enforcing
--quietinproxy_modewill not cause any other problems, since if we track the usages of theCfg.quietflag, so far the only dependency chain I can find in the codebase is the following:Since the difference is so subtle, no breakages has been detected since 63d63ea until the progress bar was taken into consideration by the verbosity system in v1.29, meaning the flag could have had no impact at all before the fact.
Since the progress bar is intentionally not a visible part of the test snapshots, manual test is advised to make sure the fix is correct. As for myself, I have tested it immediately with a local build and everything looks okay.
cc @bjorn3