fix: repair toolchains missing their installed manifest#4954
Open
ychampion wants to merge 3 commits into
Open
Conversation
rami3l
requested changes
Jul 12, 2026
ychampion
force-pushed
the
fix/missing-toolchain-manifest
branch
from
46a54f0 to
3a17c15
Compare
rami3l
reviewed
Jul 12, 2026
djc
reviewed
Jul 13, 2026
Contributor
Author
|
Ok looking |
ychampion
force-pushed
the
fix/missing-toolchain-manifest
branch
from
3a17c15 to
c015a92
Compare
Contributor
Author
|
Done. I rewrote both commit messages as concise subjects and verified that the resulting tree is unchanged. |
Contributor
Did you miss the earlier feedback from @rami3l? |
Tested: cargo test --features test --test test_bonanza missing_manifest Tested: cargo check --all --all-targets --features test
Contributor
Author
Yeah maybe, could you reference it? |
Contributor
I meant the commit you added, but the new commit should be squashed into the first one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A matching update hash could skip the channel manifest download even after the installed manifest was deleted, leaving the toolchain broken while rustup reported it as unchanged.
Fixes #4825.
Validation
cargo test --features=test --test test_bonanza suite::cli_rustup::- 130 passedcargo test --features=test --lib v2_manifest_checksum_mismatch_surfaces_error- passedcargo clippy --features=test --all-targets -- -D warnings- passedcargo fmt --all -- --check- passed