fix(self-update): only remove complete profile lines#4960
Merged
Conversation
cachebag
force-pushed
the
profile-line-cleanup
branch
from
9b980ab to
49c7b04
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rami3l
approved these changes
Jul 13, 2026
cachebag
force-pushed
the
profile-line-cleanup
branch
from
49c7b04 to
ec958cc
Compare
rami3l
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perusing older issues; this PR fixes #2967 by preventing shell profile cleanup from removing rustup source commands embedded within larger shell expressions.
Cleanup previously matched arbitrary byte substrings, which could truncate guarded commands such as
[ -f "$HOME/.cargo/env" ] && source "$HOME/.cargo/env". Matching now requires the command to begin at a line boundary; the existing trailing newline enforces the end boundary.I found an earlier fix attempt in #3092 but it seemed to be abandoned and had a bit of a different approach.
Closes #2967