Open
Conversation
erickt
force-pushed
the
fix-tests
branch
2 times, most recently
from
45a0405 to
712d758
Compare
djc
reviewed
Feb 16, 2026
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Thanks for working on this!
This commit has a lot going on, and I'd like it to be split into smaller commits that make one logical change:
- Replace use of existing binaries with using
cargo run - Using a random port
- Potentially other commits with miscellaneous changes
Before this patch, the `server` and `custom_ca_store` tests would run on either port 1337 or 1338, but some other process could be using those ports, which would confuse the results. This changes the tests to instead use a random port in order to be more consistent.
Contributor
Author
|
I broke up the PR into a few patches, or would you rather them to be separate PRs? I did however leave out the "run using cargo" change since I realized that that would change the test semantics. At the moment the examples are built with whatever flags you specify, but my change would hardcode the list. That change could be useful, but we could consider it in a separate PR. I'll update the PR description with this in mind. |
erickt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the tests to run on a random port rather than fixed ones in order to avoid a potential conflict with other processes using ports 1337 or 1338. It also adds a few asserts to log the STDOUT or STDERR if the example
clientorserverfails for some reason.