This repository was archived by the owner on Dec 12, 2021. It is now read-only.
Uses length validation to hide add link when you reach maximum # of nested objects#243
Closed
michaelglass wants to merge 2 commits into
Closed
Uses length validation to hide add link when you reach maximum # of nested objects#243michaelglass wants to merge 2 commits into
michaelglass wants to merge 2 commits into
Conversation
…ts as defined in length validation.
Contributor
Author
|
... so Sebastian's thread had some activity, but here there have been crickets. If I more thoroughly test this feature, will it get merged in? <3 |
|
I would be very interested in this feature. Hope it gets merged in. It'd be great if there was a 'minimum' check as well. |
|
+1 for this. Any update? |
Contributor
Author
|
assuming this is dead. closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no tests yet, but this should work.
continued to implement #46, adding prototype and a few small changes:
by default, using length validators will not be used.
use length validatiors globally with
in your application.rb
use length validations on a per-association level by passing the :check_maximum option
if check_maximum is passed in but a validator can't be chosen (either because there are none or more than 1) link_to_add will raise an NestedForm::UnresolvedLengthValidator error
if you just want to set a maximum without checking a length validator, pass it in
this will override any length validators