Fix postgres execution not respecting configuration values

[nicholas-rees]

What does this PR do?

Modifies the postgres execution module to respect the configuration set by changing all calls from config.option to config.get and setting the string delimiters to colons.

As noted in the related issue I opened:

# salt-call config.option

Passed invalid arguments: option() missing 1 required positional argument: 'value'.

Usage:

Returns the setting for the specified config value. The priority for
matches is the same as in :py:func:`config.get <salt.modules.config.get>`,
only this function does not recurse into nested data structures. Another
difference between this function and :py:func:`config.get
<salt.modules.config.get>` is that it comes with a set of "sane defaults".
To view these, you can run the following command:

It seems like config.option is just the wrong function to use and config.get is the correct one.

Before this fix:

# salt-call postgres.psql_query "SELECT current_user, session_user;"
local:
    |_
      ----------
      current_user:
          postgres
      session_user:
          postgres

After:

# salt-call postgres.psql_query "SELECT current_user, session_user;"
local:
    |_
      ----------
      current_user:
          salt_admin
      session_user:
          salt_admin

I do not know if this should go in the 3006.x. I sort of suspect that it should but I have not tested this at all on 3006.x so I have made this PR. If you would like to change it to 3006.x let me know and I can do that work.

What issues does this PR fix or reference?

Fixes #69971

Previous Behavior

postgres module was not respecting the configuration set in either the pillars or minion configuration file.

New Behavior

postgres module now respects configuration values.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

[twangboy]

Because config.option("postgres.bins_dir") uses . as a flat key lookup, switching to config.get("postgres:bins_dir") without specifying delimiter='.' means Salt will no longer match the exact configuration keys shown in its own module documentation.

All config.get calls should use delimiter="." to avoid breaking existing configs.

Also, when switching to config.get, any lookup for an option that requires a non-None fallback (like a default port 5432 or default database "postgres") should explicitly pass default=.... Otherwise, missing config keys silently return None into functions that might not be expecting None.

And yes, this should go onto 3006.x

[twangboy]

Delimiter Syntax Change (postgres.bins_dir vs postgres:bins_dir)

• Switching from config.option to config.get` changes the default string delimiter from .to:``.
• If existing users have keys configured as postgres.bins_dir, postgres.host, or postgres.user in their minion configs, config.get("postgres:bins_dir") will fail to find them unless the delimiter='.' argument is passed or the lookups are explicitly structured to support legacy dot notation.
• Standard Salt convention for config.get lookup with dot-separated string keys requires setting delimiter='.':

__salt__["config.get"]("postgres.bins_dir", delimiter=".")

[twangboy]

Same thing here, pass delimiter="."

[twangboy]

Same here: delimiter="."

[nicholas-rees]

Because I had to change the branch to 3006.x, I had to either force push, rename, or delete the previous branch in order to be sure the commits would line up. When doing so, that caused this PR to be closed.

You can find the new MR at #70013.