Add implementations for FG WP runtime spatial hash#339
Draft
Th3Fanbus wants to merge 1 commit intosatisfactorymodding:devfrom
Draft
Add implementations for FG WP runtime spatial hash#339Th3Fanbus wants to merge 1 commit intosatisfactorymodding:devfrom
Th3Fanbus wants to merge 1 commit intosatisfactorymodding:devfrom
Conversation
Contributor
Author
|
Currently fails to build due to missing stuff about |
Add the implementations of `FGWorldPartitionRuntimeSpatialHash.cpp` and
`FWPSaveDataMigrationContext.cpp`, kindly provided by Archengius. These
should allow custom levels that use World Partition. The level must use
the `FGWorldPartitionRuntimeSpatialHash` class (using the default class
will result in a cast failure crash), but it was impossible to cook the
level with the stubs we had in the project.
Arch also provided `FWPSaveDataMigrationContext.cpp` as it gets used by
`FGWorldPartitionRuntimeSpatialHash.cpp` to generate WP migration data,
needed to support WP migration for modded WP worlds.
TODO: I had to implement a function in FGObjectReference.cpp but I have
no idea if the implementation is correct. Without this function's
definition, the Arch-provided code does not build (linker error).
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Th3Fanbus
force-pushed
the
wp-runtime-spatial-hash
branch
from
c835bc0 to
4d25750
Compare
Contributor
Author
|
If I understood Arch (https://discord.com/channels/555424930502541343/555515791592652823/1357645226432270496) correctly, the missing function is this: FArchive& operator<<(FArchive& ar, FObjectReferenceDisc& reference)
{
ar << reference.LevelName;
ar << reference.PathName;
return ar;
}
|
Contributor
Author
|
Awaiting updated files for 1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the implementations of
FGWorldPartitionRuntimeSpatialHash.cppandFWPSaveDataMigrationContext.cpp, kindly provided by Archengius. These should allow custom levels that use World Partition. The level must use theFGWorldPartitionRuntimeSpatialHashclass (using the default class will result in a cast failure crash), but it was impossible to cook the level with the stubs we had in the project.Arch also provided
FWPSaveDataMigrationContext.cppas it gets used byFGWorldPartitionRuntimeSpatialHash.cppto generate WP migration data, needed to support WP migration for modded WP worlds.Should address #315