Skip to content

Conversation

@script3r
Copy link
Owner

@script3r script3r commented Sep 15, 2025

Require import+API; remove confidence/flags; add gating tests; docs + clippy + fmt

Why

  • Reduce false positives and simplify configuration.
  • Make detection semantics explicit and testable.

Changes

  • Require both an anchor (import/include/namespace) and at least one API match for libraries that define anchors.
  • Remove confidence from findings and delete all related logic.
  • Drop CLI/config flags: --min-confidence, --fail-on-find, --allow, --deny.
  • Clean up comments and references to deprecated behavior.

Tests

  • Add anchors test (Google Tink/Java): import-only → no hit; API-only → no hit; import+API → hit.
  • Add filtering tests:
    • Commented import suppression for Java JCA/JCE.
    • PHP OpenSSL API-only detection still works (no anchors).
    • include_glob correctly filters languages.
    • max_file_size skips large files.

Docs

  • Update README and static demo JSON (confidence removed; flags removed).

Quality

  • cargo test --workspace: passing.
  • cargo clippy --workspace --all-targets -- -D warnings: clean.
  • cargo fmt --all -- --check: clean.

Breaking changes

  • Output schema change: confidence field removed.
  • CLI flags removed: --min-confidence, --fail-on-find, --allow, --deny.

@cursor cursor bot force-pushed the feat/cipherscope-scan-test branch from 104b5ab to 09a80b0 Compare September 15, 2025 11:02
@script3r script3r merged commit 4994956 into main Sep 15, 2025
4 checks passed
@script3r script3r deleted the feat/cipherscope-scan-test branch September 21, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants