Optimize large repo file listing performance #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: script3r <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: script3r <[email protected]>
Co-authored-by: script3r <[email protected]>
Co-authored-by: script3r <[email protected]>
Co-authored-by: script3r <[email protected]>
Co-authored-by: script3r <[email protected]>
…quential - Replace ignore crate's build_parallel().run() with sequential builder.build() - The parallel walker doesn't guarantee thread completion before returning - Sequential discovery followed by parallel processing with rayon is more reliable - Eliminates the hanging thread issue that prevented app termination - Maintains performance through parallel file processing
Fix scanning thread hang
Co-authored-by: script3r <[email protected]>
…anning-and-add-progress-613b Optimize slow directory scanning and add progress
script3r
deleted the
cursor/optimize-large-repo-file-listing-performance-e60f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve file discovery performance for large repositories by adding a Git fast path and parallelizing directory traversal.
This PR introduces two main optimizations: first, it leverages
git ls-filesfor Git repositories to quickly list tracked and unignored files, similar to howripgrepoperates. Second, for non-Git repositories or when the Git fast path is not applicable, it switches to a parallel directory walker (ignorecrate) with early glob filtering and reduced metadata calls to minimize I/O overhead.