Skip to content

Conversation

@LucaMarconato
Copy link
Member

Closes #1037

Simple PR:

  • removes to_dask_array() and calls compute right away (it would be called later in the code anyway);
  • improve error messages, typing and check on related parts of the codebase.

Please @melonora do a post-merge double check.

@LucaMarconato LucaMarconato enabled auto-merge (squash) January 3, 2026 16:35
@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.19%. Comparing base (428791b) to head (bb7372a).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata/_core/query/spatial_query.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   92.20%   92.19%   -0.02%     
==========================================
  Files          49       49              
  Lines        7547     7545       -2     
==========================================
- Hits         6959     6956       -3     
- Misses        588      589       +1     
Files with missing lines Coverage Δ
src/spatialdata/_core/query/spatial_query.py 95.17% <77.77%> (-0.30%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaMarconato LucaMarconato merged commit d013fe0 into main Jan 3, 2026
11 checks passed
@LucaMarconato LucaMarconato deleted the fix/dask-attrs-query branch January 3, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dask-expr problem: the number of items in 'lengths' does not match the number of partitions. 2 != 4

2 participants