Conversation
jvbreen1
reviewed
May 26, 2022
Contributor
jvbreen1
left a comment
jvbreen1
left a comment
There was a problem hiding this comment.
I'm not super familiar with Eleventy itself, but this looks good to me! I did leave one comment about the link for submitting PRs.
| <div class="box"> | ||
| <h2 class="sub-headline">Ways to help</h2> | ||
| <ol class="list"> | ||
| <li>Submit words and definitions or contribute to our code base through <a href="https://github.com/tatianamac/selfdefined/pulls" rel="noreferrer">pull requests</a> or <a href="https://github.com/tatianamac/selfdefined/issues" rel="noreferrer">issues</a>. Start with our <a href="https://github.com/selfdefined/web-app/blob/prod/CONTRIBUTING.md" rel="noreferrer">contributing guidelines</a> and <a href="/documentation/">documentation</a>.</li> |
Contributor
There was a problem hiding this comment.
Is this link correct? I don't think the codebase is in Tatiana's personal github anymore, is it?
Collaborator
There was a problem hiding this comment.
This is correct. @kkemple Do you want to fix this in this PR? It’s not strictly in the scope of it, so we can fix this separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains work for moving the dictionary to a dedicated page. As a by-product of that, content has moved from the home page to more dedicated pages as well, and a basic navigation has been added.
Related Issue
#183
Motivation and Context
The goal is to open up the home page to speak more about the project and highlight important information about the project and supporting it.
How Has This Been Tested?
So far only locally on my machine and brief QA with @tatianamac
Screenshots (if appropriate):
Types of changes
Checklist: