Move from pyranges to ruranges#241
Merged
tomwhite merged 2 commits intosgkit-dev:mainfrom Mar 10, 2026
Merged
Conversation
Member
Oh dear. Hopefully there's no strong reason for this and support for older python versions can be added |
Member
Author
|
I've updated the code to support both pyranges and ruranges, and to depend on pyranges for Python < 3.12 and ruranges otherwise. We can drop the pyranges code when we remove Python 3.11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111
It was actually fairly straightforward to switch to ruranges - all the tests pass locally. However, ruranges has a minimum Python version of 3.12, so we can't merge this yet.
Also, we can't remove the pandas dependency (one of the motivations for #111) since we use it for plink.