Open
Conversation
Contributor
|
Thanks for the PR @matte1 we really appreciate it! The changes look good to me, and great comments! I think it just needs a run of For merging, we follow a commit message pattern of |
matte1
force-pushed
the
matte1/backup_manager_fixes
branch
from
0159861 to
6dd2913
Compare
tsift
reviewed
Feb 11, 2026
| error = %e, | ||
| "unable to write buffered data during drop, data may be lost" | ||
| ); | ||
| return; |
Contributor
There was a problem hiding this comment.
Even if the write here fails, attempting sync_all as well might help limit what could be lost. But if the write is failing, probably a good chance that sync_all will also fail.
Verification: Added unit test that demonstrates the issue. Testing this without the fix causes this unit test to fail.
Verification: Added a unit test that previously would fail and now passes.
Verification: Added unit tests showing the that message id of 0 is handled correctly.
Verification: Unit tests
matte1
force-pushed
the
matte1/backup_manager_fixes
branch
from
6dd2913 to
889f9cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Random fixes to the sift stream backup manager.