Get services from signing config for prober #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlew02
force-pushed
the
prober-sc
branch
2 times, most recently
from
6d7497b to
a48255f
Compare
aaronlew02
force-pushed
the
prober-sc
branch
11 times, most recently
from
4e9b3b3 to
e1223a7
Compare
aaronlew02
force-pushed
the
prober-sc
branch
17 times, most recently
from
25bf6c5 to
b5e1bc3
Compare
aaronlew02
force-pushed
the
prober-sc
branch
2 times, most recently
from
d466671 to
e0e15ae
Compare
aaronlew02
force-pushed
the
prober-sc
branch
from
e0e15ae to
9a063e9
Compare
aaronlew02
force-pushed
the
prober-sc
branch
2 times, most recently
from
a66fedb to
afceb43
Compare
aaronlew02
force-pushed
the
prober-sc
branch
from
afceb43 to
4d8adde
Compare
haydentherapper
previously approved these changes
Sep 19, 2025
Contributor
haydentherapper
left a comment
haydentherapper
left a comment
There was a problem hiding this comment.
Just one minor comment, this looks great!
aaronlew02
force-pushed
the
prober-sc
branch
2 times, most recently
from
ccdbd44 to
2f4c421
Compare
cmurphy
reviewed
Sep 19, 2025
Signed-off-by: Aaron Lew <[email protected]>
aaronlew02
force-pushed
the
prober-sc
branch
from
2f4c421 to
3c1ee2d
Compare
haydentherapper
approved these changes
Sep 22, 2025
cmurphy
approved these changes
Sep 22, 2025
10 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses sigstore/rekor-tiles#46
Summary
This change updates the prober to get its Fulcio, Rekor, and timestamping services from a signing config (TUF signing config v0.2 by default, unless overridden by a flag) instead of URL flags.