-
Notifications
You must be signed in to change notification settings - Fork 67
feat: add merkle tree test suite #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Relates to: sigstore#283 Signed-off-by: Victor Embacher <[email protected]>
…added some functionality. Relates to: sigstore#283 Signed-off-by: Victor Embacher <[email protected]>
Signed-off-by: Victor Embacher <[email protected]>
…tions. Signed-off-by: Victor Embacher <[email protected]>
Signed-off-by: Victor Embacher <[email protected]>
Signed-off-by: Victor Embacher <[email protected]>
Signed-off-by: Victor Embacher <[email protected]>
…ion proofs at this level Signed-off-by: Victor Embacher <[email protected]>
…ypes Signed-off-by: Victor Embacher <[email protected]>
Signed-off-by: Victor Embacher <[email protected]>
Signed-off-by: Victor Embacher <[email protected]>
…ctions Signed-off-by: Victor Embacher <[email protected]>
Signed-off-by: Wolf Vollprecht <[email protected]>
Signed-off-by: Wolf Vollprecht <[email protected]>
Signed-off-by: Wolf Vollprecht <[email protected]>
Signed-off-by: Wolf Vollprecht <[email protected]>
temporarily disable failing doctest (needs dsse) Signed-off-by: Wolf Vollprecht <[email protected]>
|
Looks like the upstream tests are also passing in this branch! :) I also made the PR to @vembacher repository. I did have to merge main and get rid of a few merge conflicts, which is why the PR looks a bit messy: vembacher#1 I'll tackle the remaining cargo hack issues. |
Signed-off-by: Wolf Vollprecht <[email protected]>
Signed-off-by: Wolf Vollprecht <[email protected]>
Signed-off-by: Wolf Vollprecht <[email protected]>
Signed-off-by: Wolf Vollprecht <[email protected]>
|
Thanks @flavio for merging |
|
Hi, thanks for tackling this. Sadly, I cannot humanly review a merge commit with 89 changed files nor I can blindly trust it. Hence I elected to perform it on my own plus minimal fixes on #285. Can you rebase or cherry pick 484468e on top of the current state of #285 please? In addition, that commit will not pass |
|
I'm happy to make a new PR with the test suite after vembachers pr is merged. This was mostly a demonstration that tests pass. |
Summary
Release Note
Documentation