Skip to content

Conversation

@wolfv
Copy link
Contributor

@wolfv wolfv commented Nov 17, 2025

Summary

Release Note

Documentation

vembacher and others added 20 commits March 20, 2024 10:30
Relates to: sigstore#283

Signed-off-by: Victor Embacher <[email protected]>
…added some functionality.

Relates to: sigstore#283

Signed-off-by: Victor Embacher <[email protected]>
Signed-off-by: Victor Embacher <[email protected]>
Signed-off-by: Victor Embacher <[email protected]>
…ion proofs at this level

Signed-off-by: Victor Embacher <[email protected]>
Signed-off-by: Victor Embacher <[email protected]>
Signed-off-by: Wolf Vollprecht <[email protected]>
Signed-off-by: Wolf Vollprecht <[email protected]>
temporarily disable failing doctest (needs dsse)

Signed-off-by: Wolf Vollprecht <[email protected]>
@wolfv
Copy link
Contributor Author

wolfv commented Nov 17, 2025

Looks like the upstream tests are also passing in this branch! :)

I also made the PR to @vembacher repository. I did have to merge main and get rid of a few merge conflicts, which is why the PR looks a bit messy: vembacher#1

I'll tackle the remaining cargo hack issues.

Signed-off-by: Wolf Vollprecht <[email protected]>
Signed-off-by: Wolf Vollprecht <[email protected]>
@wolfv wolfv mentioned this pull request Nov 17, 2025
5 tasks
Signed-off-by: Wolf Vollprecht <[email protected]>
@wolfv
Copy link
Contributor Author

wolfv commented Nov 18, 2025

Thanks @flavio for merging serde_json_canonicalizer! Merged main again, and moved everything over from olpc-cjson.

@viccuad
Copy link
Collaborator

viccuad commented Nov 21, 2025

Hi, thanks for tackling this.

Sadly, I cannot humanly review a merge commit with 89 changed files nor I can blindly trust it. Hence I elected to perform it on my own plus minimal fixes on #285.

Can you rebase or cherry pick 484468e on top of the current state of #285 please?

In addition, that commit will not pass make test locally. For that, I would like the merkle tests to be gated under a feature, and a new make target to run them. For now we can keep obtaining the testcase files as a manual step; I would like to keep it simple without submodules, nor importing the history of transparency-dev/merkle, nor copy-pasting them and needing to diff between the repos every time they are updated.

@wolfv
Copy link
Contributor Author

wolfv commented Nov 21, 2025

I'm happy to make a new PR with the test suite after vembachers pr is merged. This was mostly a demonstration that tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants