Propagate part-ref caller through NodeChildrenDisplayCommand#1009
Closed
johnml1135 wants to merge 3 commits into
Closed
Propagate part-ref caller through NodeChildrenDisplayCommand#1009johnml1135 wants to merge 3 commits into
johnml1135 wants to merge 3 commits into
Conversation
NodeChildrenDisplayCommand always passed a null caller to ProcessChildren, even when it originated from a "part" node in XmlViewsUtils.GetDisplayCommandForColumn1. Child fragments that resolve attributes (e.g. "ws" for multilingual strings) from the caller got nothing and rendered blank, matching XmlVc's own "part" handling which does pass a non-null caller through ProcessChildren. Carry the part-ref node down as the caller so both paths agree. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
=======================================
Coverage 32.97% 32.98%
=======================================
Files 1202 1202
Lines 278291 278299 +8
Branches 37166 37168 +2
=======================================
+ Hits 91776 91786 +10
+ Misses 158649 158647 -2
Partials 27866 27866
🚀 New features to boost your workflow:
|
Addresses the "no test added" gap noted in the PR description: pins that a <part ref="..."/> column-spec node carries itself down as the resulting NodeChildrenDisplayCommand's Caller, so child fragments that read attributes (e.g. "ws") from the caller resolve correctly instead of rendering blank. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from a rebase hunk found on the Avalonia migration branch (#964) — pulled out because it changes shared, legacy-reachable rendering behavior and shouldn't ride along in that PR. Opening this as a draft for team discussion, not as a confident fix.
XmlViewsUtils.GetDisplayCommandForColumn1's"part"case builds aNodeChildrenDisplayCommand(part)and always passes anullcaller intoProcessChildren.XmlVc's own"part"handling passes a non-null caller in the equivalent situation. This change makes the two agree by carrying the part-ref node down as the caller.There's a pre-existing
// Review JohnT:comment sitting right on this code inXmlViewsUtils.cs(removed by this diff) that names exactly this gap and says it couldn't be confirmed to matter:Uncertainty — please weigh in
maintoday? The rebase hunk's comment referenced "the 'Grammatical Info.' blank column bug in the Avalonia browse table" with an unfilledLT-ticket reference — I don't have a real ticket number and haven't reproduced a blank-column bug onmainmyself. I can't confirm this fixes a live bug vs. a bug that only manifests once the Avalonia browse-column path exists.XMLViews.csproj, 0 errors/warnings) and no other call site depends on the old single-arg-only shape.Test plan
"part"-based browse column that reads a caller-relative attribute (e.g.ws)🤖 Generated with Claude Code
This change is