Skip to content

SF-3841 Fix book order for quality estimation results#3983

Open
pmachapman wants to merge 1 commit into
masterfrom
fix/SF-3841
Open

SF-3841 Fix book order for quality estimation results#3983
pmachapman wants to merge 1 commit into
masterfrom
fix/SF-3841

Conversation

@pmachapman

@pmachapman pmachapman commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Jul 7, 2026
@pmachapman
pmachapman temporarily deployed to screenshot_diff July 7, 2026 01:09 — with GitHub Actions Inactive
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.03%. Comparing base (0be7d55) to head (d2b59bd).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...SIL.XForge.Scripture/Services/MachineApiService.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3983      +/-   ##
==========================================
- Coverage   81.03%   81.03%   -0.01%     
==========================================
  Files         645      645              
  Lines       41463    41463              
  Branches     6750     6755       +5     
==========================================
- Hits        33600    33599       -1     
- Misses       6755     6756       +1     
  Partials     1108     1108              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/SIL.XForge.Scripture/Services/MachineApiService.cs line 1202 at r1 (raw file):

            ProjectId = id[0],
            BuildId = id[1],
            BookConfidences = [.. draftMetrics.BookConfidences.OrderBy(c => c.BookNum)],

Only one concern: Is it possible for the chapters to be out of order as well? I'm guessing that would be less common, but maybe still possible?

Non-blocking.

@Nateowami Nateowami self-assigned this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants