SF-3804 Use the verse following a selected heading when adding questions

[pmachapman]

This change is 

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.06%. Comparing base (f27c954) to head (c49ede8).
⚠️ Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
...re/ClientApp/src/app/shared/text/text.component.ts	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3987      +/-   ##
==========================================
+ Coverage   81.02%   81.06%   +0.04%     
==========================================
  Files         645      645              
  Lines       41538    41551      +13     
  Branches     6743     6766      +23     
==========================================
+ Hits        33656    33685      +29     
+ Misses       6780     6754      -26     
- Partials     1102     1112      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[RaymondLuong3]

Just a couple non-blocking comments.

@RaymondLuong3 reviewed 3 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on pmachapman).

---

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking.component.ts line 1088 at r1 (raw file):

        // If this segment is not a verse segment, keep looking down the chapter until we get a verse segment
        while (verseRef == null) {
          segmentRef = this.scripturePanel?.textComponent.getNextSegmentRef(segmentRef);

Nit: The null coalescing is not necessary.

Code quote:

this.scripturePanel?

---

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking.component.ts line 1097 at r1 (raw file):

          segmentRef = this.scripturePanel.textComponent.segmentRef;
          while (verseRef == null) {
            segmentRef = this.scripturePanel?.textComponent.getPrevSegmentRef(segmentRef);

Nit: Same as above

Code quote:

segmentRef = this.scripturePanel?.

[pmachapman]

@pmachapman made 2 comments and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

---

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking.component.ts line 1088 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

Nit: The null coalescing is not necessary.

Done.

---

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking.component.ts line 1097 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

Nit: Same as above

Done.