Implement Luocha #294
Open
Implement Luocha #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* init + skeleton + data * implement stats, attack, skill (without insert), talent (with workaround for sub modifiers), E1, E2, E4, A2, A4 To-Do: * implement ult, E6, technique, A6, insert
* implement ult, E6, technique, A6 * move most of Eidolon logic to `eidolon.go` * add missing key and import * fix typos To-Do: * finish skill insert
* continue inserted skill implementation * refactored some functions * added helper functions * rename insert names to better differentiate between inserted skill and talent insert To-Do: * finish insert skill * potentially refactor skill so that it can be run by main skill and insert skill
* refactor `Skill` and `InsertSkill` to use helper function `ExecuteSkill` * comment out IsInsert variable * simplify isMinHPRatio function * finish skill and talent * fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional notes:
IsInsertsetting and resetting is commented out as the functionality needs to be checked (probably a global variable that is used somewhere to check for action being insert or not, but this should be covered by the way inserts are implemented in srsim (cmiiw))