Open
Conversation
Previously some gems masked a bug in Rails v6 and v7 where `logger` was not required, plugging the hole by requiring it themselves. Because this app is pinned to Rails v6.1, we must require logger manually. In order to not be reliant on other libraries to fix the bug in Rails for us, we do it too. See: https://stackoverflow.com/questions/79360526/uninitialized-constant-activesupportloggerthreadsafelevellogger-nameerror
- explicit proxy for determining if running in parallel
- `created_at` / `timestamp` is for wall clock time (for humans) - `started_at` is for monotonic / elapsed time (for computers)
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important background: Monotonic time is the "correct" way to calculate elapsed time in Ruby:
https://blog.dnsimple.com/2018/03/elapsed-time-with-ruby-the-right-way/
started_atbased on the monotonic clock which is guaranteed to always move forward (processor uptime)created_at/timestampbased onProcess.clock_gettime(Process::CLOCK_REALTIME), to avoidTime.nowstubbing & Timecop issuesI do not understand the rubocop failure in CI, because when I run locally there are no violations:
Same result when run with
bundle exec rake rubocopas it is in CI.CC @ilyazub