Skip to content

PITR: fix clones and restore#672

Merged
boddumanohar merged 1 commit intodevfrom
pitr-fix-clones
Apr 2, 2026
Merged

PITR: fix clones and restore#672
boddumanohar merged 1 commit intodevfrom
pitr-fix-clones

Conversation

@boddumanohar
Copy link
Copy Markdown
Member

@boddumanohar boddumanohar commented Mar 18, 2026 •
edited
Loading

fixes: simplyblock/vela#298

When branches with PITR enabled are cloned or restored from a snapshot the WAL PVC should also be considered. this changes makes sure that WAL PVC is also cloned along with DATA PVC>

testing

The current functionality is already tested with the passing tests. Failure for branch start/stop tests are not related.

have created a branch with PITR enabled and cloned the branch and also created a new branch from a backup. both the functionalities work.

@boddumanohar boddumanohar changed the title Pitr fix clones PITR: fix clones and restore Mar 18, 2026
Base automatically changed from dev to main March 19, 2026 14:34
@boddumanohar boddumanohar changed the base branch from main to dev March 22, 2026 18:27
@boddumanohar boddumanohar marked this pull request as draft March 24, 2026 13:54
Base automatically changed from dev to main March 25, 2026 12:30
@boddumanohar boddumanohar changed the base branch from main to dev March 25, 2026 13:27
@boddumanohar boddumanohar requested a review from mxsrc March 31, 2026 16:19
@boddumanohar boddumanohar marked this pull request as ready for review March 31, 2026 16:19
@mxsrc
Copy link
Copy Markdown
Collaborator

mxsrc commented Apr 1, 2026

Is this tested?

@boddumanohar
Copy link
Copy Markdown
Member Author

boddumanohar commented Apr 1, 2026

The tests are passing to make sure that these changes doesn't break any of the existing functionality. I'll tested with a few days back. Will do tests again and update the PR desc.

@boddumanohar
Copy link
Copy Markdown
Member Author

boddumanohar commented Apr 1, 2026

Snapshot restore to the same size is not allowed for Simplyblock volumes. So due to this reason WAL PVC creation fails.

POST: New size 107374182400 must be higher than the original size 107374182400

will find a solution for this and fix it.

@boddumanohar
Copy link
Copy Markdown
Member Author

boddumanohar commented Apr 1, 2026

This issue is fixed in the latest release of sbcli. So I've updated the cluster and tested the changes again. Works good without any additional changes.

mxsrc
mxsrc approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mxsrc mxsrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/deployment/kubernetes/volume_clone.py

logger = logging.getLogger(__name__)

_PITR_WAL_PVC_SIZE_BYTES: int = int(parse_quantity(PITR_WAL_PVC_SIZE))
Copy link
Copy Markdown
Collaborator

@mxsrc mxsrc Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't the size itself already in bytes?

Copy link
Copy Markdown
Member Author

@boddumanohar boddumanohar Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vela-controller/src/deployment/__init__.py

Line 81 in fd4a82c

PITR_WAL_PVC_SIZE = "100Gi"

This was already written as 100Gi. For the sake of readability.

@boddumanohar boddumanohar merged commit dafd6d8 into dev Apr 2, 2026
11 of 14 checks passed
@boddumanohar boddumanohar deleted the pitr-fix-clones branch April 2, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxsrc mxsrc mxsrc approved these changes

Assignees

No one assigned

Labels

deploy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@boddumanohar @mxsrc