improvement(timeouts): files/base64 should use max timeouts + auth centralization#3179
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR centralizes file download timeouts by switching several call sites from fixed 180s defaults to higher/max execution timeouts. Specifically, it increases the job status endpoint’s The main concern is that Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller
participant FU as file-utils.server.ts
participant DV as input-validation.server
participant Fetch as secureFetchWithPinnedIP
participant Storage as storage-service
Caller->>FU: downloadFileFromUrl(fileUrl, timeoutMs?)
alt Internal file URL
FU->>Storage: downloadFile({key, context})
Storage-->>FU: Buffer
FU-->>Caller: Buffer
else External URL
FU->>DV: validateUrlWithDNS(fileUrl)
DV-->>FU: {isValid, resolvedIP}
FU->>Fetch: secureFetchWithPinnedIP(url, resolvedIP, {timeout})
Fetch-->>FU: Response
FU-->>Caller: Buffer
end
Note over FU: PR sets default timeoutMs = getMaxExecutionTimeout()
|
Additional Comments (1)
|
|
@cursor review |
|
@cursor review |
|
bugbot run |
|
bugbot run |
|
bugbot run |
Summary
Type of Change
Testing
Tested manually
Checklist