fix(jsm): jsm requestTypeId requirement

[emir-karabeg]

Summary

Makes the serviceDeskId parameter required in the JSM block configuration (jira_service_management.ts). Previously, serviceDeskId was optional in the UI, but it is a mandatory parameter for the JSM API's create_request operation and other JSM operations. This change prevents runtime API failures when users leave this field blank.

Fixes #(issue) - No specific issue number provided, so leaving as a placeholder.

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation
• Other: ___________

Testing

The change was verified by re-reading the file to confirm required: true was added to the serviceDeskId subBlock. TypeScript type checking (tsc) and linting commands were run and passed successfully. No specific JSM block tests were found or added.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

N/A

---

Slack Thread

  

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Feb 20, 2026 6:57pm

[greptile-apps]

Greptile Summary

Adds required: true to the serviceDeskId subBlock in the JSM block configuration. This aligns the UI validation with the existing tool-level and params-level enforcement, preventing users from leaving the field blank and encountering runtime API failures.

• Adds required: true to serviceDeskId in jira_service_management.ts, matching the pattern already used by requestTypeId, issueIdOrKey, and other mandatory fields
• The field's condition already restricts visibility to only the operations that need it (create_request, get_request_types, get_customers, etc.), so the required: true only applies when the field is shown
• No behavioral changes to the API layer — the tool params and tools.config.params already enforced this; this fix adds the missing UI-layer enforcement

Confidence Score: 5/5

• This PR is safe to merge — it's a minimal, single-line fix that adds missing UI validation already enforced at other layers.
• The change is a one-line addition of required: true to a subBlock that already has tool-level and params-level enforcement. It follows the exact same pattern used by other required fields in the same file. No logic changes, no new code paths, and no risk of regression.
• No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/blocks/blocks/jira_service_management.ts	Single-line addition of required: true to serviceDeskId subBlock — aligns UI validation with existing tool-level enforcement. No issues found.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User selects JSM operation] --> B{Operation requires serviceDeskId?}
    B -->|No| C[Field hidden via condition]
    B -->|Yes| D[serviceDeskId field shown]
    D --> E{User provides value?}
    E -->|Yes| F[Proceed to execution]
    E -->|No - Before fix| G[No UI warning]
    G --> H[Runtime API error]
    E -->|No - After fix| I["UI shows required indicator (*)"]
    I --> J[Serializer validates required fields]
    J --> K[WorkflowValidationError: missing serviceDeskId]

Loading

_{Last reviewed commit: 67d2d11}

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}