improvement(apollo): align tools and block with Apollo API docs#4487
improvement(apollo): align tools and block with Apollo API docs#4487waleedlatif1 wants to merge 15 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview This expands supported filters/fields for people/org/contact/account/opportunity operations, adjusts several endpoints and parameter conventions (notably organization enrich/bulk enrich and opportunity search), and refines response parsing to handle multiple Apollo payload shapes. Bulk create/update flows are reworked to support dedupe/labels, uniform updates via Reviewed by Cursor Bugbot for commit 69aa833. Configure here. |
Greptile SummaryThis PR aligns all 25 Apollo tools and the block with the official Apollo API by fixing endpoints, correcting request shapes, adding documented optional fields, and preserving backwards compatibility through subblock migrations and params remapping. All issues flagged in earlier review rounds have been addressed in subsequent commits.
Confidence Score: 5/5This PR is safe to merge — all previously flagged validation gaps and remapping omissions have been resolved, and the remaining changes are additive optional fields with no breaking effect. All runtime guards (empty bulk-update bodies, object-form attributes without target IDs, sequence add without identifiers) are now present and logically correct. The params remapping in the block correctly renames every renamed sub-block field before it reaches the underlying tool, including the previously missing task_notes → note. The subblock migration table covers the renamed opportunity fields. No new unguarded paths were introduced. No files require special attention; the most complex logic (account_bulk_update.ts, contact_bulk_update.ts, and the apollo.ts block params function) all have correct, layered validation. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
UI["Apollo Block UI\n(sub-blocks)"] --> PM["params() remapping\n• task_notes → note\n• opportunity_name → name\n• account_name → name\n• account_bulk_update_name → name\n• sequence_add_label_names → label_names\n• contact_run_dedupe → run_dedupe"]
PM --> SBM["splitBulkUpdateInput()\n(contacts / accounts field)"]
SBM -->|"strings only"| IDS["→ contact_ids / account_ids"]
SBM -->|"objects with id"| ATTRS["→ contact_attributes / account_attributes"]
SBM -->|"both"| ATTRS
IDS --> GUARDS
ATTRS --> GUARDS
subgraph GUARDS ["Runtime guards (bulk update tools)"]
G1["No update fields? → throw"]
G2["No target IDs and no attributes? → throw"]
G3["Object-form attributes without IDs? → throw"]
end
GUARDS --> API["Apollo API"]
subgraph MIGRATIONS ["Subblock migrations on workflow load"]
M1["close_date → closed_date"]
M2["stage_id → opportunity_stage_id"]
M3["contact_ids_bulk → contacts"]
M4["account_ids_bulk → accounts"]
end
MIGRATIONS -->|"value preserved"| UI
Reviews (7): Last reviewed commit: "fix(apollo): mirror bulk_update guard, p..." | Re-trigger Greptile |
e59ab46 to
7447852
Compare
|
@greptile |
|
@cursor review |
|
bugbot run |
|
@cursor review |
|
@greptile |
|
@greptile |
|
@cursor review |
|
@greptile |
|
@cursor review |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ff98127. Configure here.
…ation, expose account_bulk_create options
|
@greptile |
|
@cursor review |

Summary
Type of Change
Testing
Tested manually. Lint and typecheck pass.
Checklist