Skip to content

Block processor void block trailinghtml #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sirreal wants to merge 4 commits into from
Closed

Block processor void block trailinghtml #20

sirreal wants to merge 4 commits into from

Conversation

@sirreal
Copy link
Owner

@sirreal sirreal commented Jan 21, 2026

Noodling…

dmsnell
dmsnell reviewed Jan 21, 2026
View reviewed changes
tests/phpunit/tests/block-processor/wpBlockProcessor.php
'abc',
),
);
$expected = parse_blocks( $html )[0];
Copy link
Collaborator

@dmsnell dmsnell Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected to use expected as expected but then expected was reassigned :)

Copy link
Owner Author

@sirreal sirreal Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was quick and dirty debugging. Keeping you on your toes 😉

(Originally I wanted a static view of what was expected, but it was more comfortable to assert "produce the same result as parse_blocks()").

dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 21, 2026
@dmsnell @sirreal
Add tests for extract_full_block_and_advance()
b8e88ce 
Initially ported from sirreal#20

Co-authored-by: Jon Surrell <[email protected]>
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 21, 2026
@dmsnell @sirreal
Add tests for extract_full_block_and_advance() (WordPress#10769)
7a3f71b 
Trac ticket: Core-64537

Initially ported from sirreal#20

Developed in: WordPress#10769
Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket

Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939).

Props jonsurrell, dmsnell.
Fixes Core-64537

Co-authored-by: Jon Surrell <[email protected]>
Github-PR: 10769
Github-PR-URL: WordPress#10769
Trac-Ticket: 64537
Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537
Branch-Name: blocks/add-block-processor-tests
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 21, 2026
@dmsnell @sirreal
Add tests for extract_full_block_and_advance() (WordPress#10769)
7153952 
Trac ticket: Core-64537

Initially ported from sirreal#20

Developed in: WordPress#10769
Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket

Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939).

Props jonsurrell, dmsnell.
Fixes Core-64537

Co-authored-by: Jon Surrell <[email protected]>
Github-PR: 10769
Github-PR-URL: WordPress#10769
Trac-Ticket: 64537
Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537
Branch-Name: blocks/add-block-processor-tests
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 21, 2026
@dmsnell @sirreal
Add tests for extract_full_block_and_advance() (WordPress#10769)
c744ac0 
Trac ticket: Core-64537

Initially ported from sirreal#20

Developed in: WordPress#10769
Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket

Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939).

Props jonsurrell, dmsnell.
Fixes Core-64537

Co-authored-by: Jon Surrell <[email protected]>
Github-PR: 10769
Github-PR-URL: WordPress#10769
Trac-Ticket: 64537
Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537
Branch-Name: blocks/add-block-processor-tests
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 21, 2026
@dmsnell @sirreal
Add tests for extract_full_block_and_advance() (WordPress#10769)
5625b82 
Trac ticket: Core-64537

Initially ported from sirreal#20

Developed in: WordPress#10769
Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket

Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939).

Props jonsurrell, dmsnell.
Fixes Core-64537

Co-authored-by: Jon Surrell <[email protected]>
Github-PR: 10769
Github-PR-URL: WordPress#10769
Trac-Ticket: 64537
Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537
Branch-Name: blocks/add-block-processor-tests
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 21, 2026
@dmsnell @sirreal
Add tests for extract_full_block_and_advance() (WordPress#10769)
93ff08b 
Trac ticket: Core-64537

Initially ported from sirreal#20

Developed in: WordPress#10769
Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket

Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939).

Props jonsurrell, dmsnell.
Fixes Core-64537

Co-authored-by: Jon Surrell <[email protected]>
Github-PR: 10769
Github-PR-URL: WordPress#10769
Trac-Ticket: 64537
Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537
Branch-Name: blocks/add-block-processor-tests
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 21, 2026
@dmsnell @sirreal
Add tests for extract_full_block_and_advance() (WordPress#10769)
95d5adc 
Trac ticket: Core-64537

Initially ported from sirreal#20

Developed in: WordPress#10769
Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket

Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939).

Props dmsnell, jonsurrell, jorbin.
Fixes Core-64537

Co-Authored-By: Jon Surrell <[email protected]>
Co-Authored-By: Aaron Jorbin <[email protected]>
Github-PR: 10769
Github-PR-URL: WordPress#10769
Trac-Ticket: 64537
Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537
Branch-Name: blocks/add-block-processor-tests
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 21, 2026
@dmsnell @sirreal
Add tests for extract_full_block_and_advance() (WordPress#10769)
d90172c 
Trac ticket: Core-64537

Initially ported from sirreal#20

Developed in: WordPress#10769
Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket

Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939).

Props dmsnell, jonsurrell, jorbin.
Fixes Core-64537

Co-Authored-By: Jon Surrell <[email protected]>
Co-Authored-By: Aaron Jorbin <[email protected]>
Github-PR: 10769
Github-PR-URL: WordPress#10769
Trac-Ticket: 64537
Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537
Branch-Name: blocks/add-block-processor-tests
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 21, 2026
@dmsnell @sirreal
Add tests for extract_full_block_and_advance() (WordPress#10769)
00c47d0 
Trac ticket: Core-64537

Initially ported from sirreal#20

Developed in: WordPress#10769
Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket

Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939).

Props dmsnell, jonsurrell, jorbin.
Fixes Core-64537

Co-Authored-By: Jon Surrell <[email protected]>
Co-Authored-By: Aaron Jorbin <[email protected]>
Github-PR: 10769
Github-PR-URL: WordPress#10769
Trac-Ticket: 64537
Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537
Branch-Name: blocks/add-block-processor-tests
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 21, 2026
@dmsnell @sirreal @aaronjorbin
Blocks: Ensure extract_full_block_and_advance() matches parse_blocks() (
ce4001d 
WordPress#10769)

Trac ticket: Core-64537

Initially ported from sirreal#20

The behavior of WP_Block_Processor::extract_full_block_and_advance()
should produce an identical output to what parse_blocks() would return
on the same substring of input.

Unfortunately, when HTML spans followed inner blocks, they were being
omitted in the output parse tree. This was due to an omission in the
original code which would look for those blocks before advancing again
after calling `extract_full_block_and_advance()` recursively.

This patch adds the missing check and resolves the discrepancy.

Developed in: WordPress#10769
Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket

Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939).

Props dmsnell, jonsurrell, jorbin.
Fixes Core-64537

Co-Authored-By: Jon Surrell <[email protected]>
Co-Authored-By: Aaron Jorbin <[email protected]>
Github-PR: 10769
Github-PR-URL: WordPress#10769
Trac-Ticket: 64537
Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537
Branch-Name: blocks/add-block-processor-tests
@dmsnell
Copy link
Collaborator

dmsnell commented Jan 21, 2026

full test suite in WordPress#10769

@dmsnell
Copy link
Collaborator

dmsnell commented Jan 22, 2026

Unless I have misread the tests or neglected something, this should be resolved as of the merge of WordPress@d3068ae

@sirreal sirreal closed this Jan 22, 2026
@sirreal sirreal deleted the block-processor-void-block-trailinghtml branch January 22, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmsnell dmsnell dmsnell left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sirreal @dmsnell