Skip to content

Conversation

@dblock
Copy link
Contributor

@dblock dblock commented Dec 30, 2025

Summary

Migrates Danger to use the danger-pr-comment reusable workflow pattern, following the same approach as:

Changes

  • Updated .github/workflows/danger.yml to use numbata/danger-pr-comment/.github/workflows/[email protected]
  • Added .github/workflows/danger-comment.yml workflow for posting PR comments
  • Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
  • Added danger-pr-comment gem to Gemfile.danger
  • Updated Ruby version from 2.7 to 3.4

Benefits

  • Cleaner workflow configuration using reusable workflows
  • Consistent with other slack-ruby repositories
  • Simplified token management (handled by reusable workflow)
  • Modern Ruby version support

🤖 Generated with Claude Code

@dblock dblock force-pushed the migrate-danger-pr-comment branch 3 times, most recently from 96917cc to ed3d79a Compare December 30, 2025 18:52
Updated to use the numbata/danger-pr-comment reusable workflow pattern,
replacing manual Danger setup with cleaner workflow delegation. This brings
the implementation in line with slack-ruby/slack-ruby-client#581 and
slack-ruby/slack-ruby-bot-server#181.

Changes:
- Updated danger.yml to use danger-run.yml reusable workflow
- Added danger-comment.yml workflow for posting PR comments
- Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
- Added danger-pr-comment gem to Gemfile.danger
- Updated Ruby version from 2.7 to 3.4

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@dblock dblock force-pushed the migrate-danger-pr-comment branch from ed3d79a to 4c48660 Compare December 30, 2025 18:54
@dblock dblock merged commit b0750aa into slack-ruby:master Dec 30, 2025
14 checks passed
@dblock dblock deleted the migrate-danger-pr-comment branch December 30, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant