refactor(web-api): align chat stream implementation with python sdk#2388
refactor(web-api): align chat stream implementation with python sdk#2388
Conversation
zimeg
added
docs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ai-apps #2388 +/- ##
==========================================
Coverage ? 93.01%
==========================================
Files ? 40
Lines ? 11112
Branches ? 713
==========================================
Hits ? 10336
Misses ? 764
Partials ? 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Looking good! Thanks for aligning the two implementations and testing the blocks!
| if (args?.markdown_text) { | ||
| this.buffer += args.markdown_text; | ||
| } |
There was a problem hiding this comment.
praise: This is a cleaner and more readable approach!
| ok: true, | ||
| }) | ||
| .post('/api/chat.stopStream', { | ||
| blocks: JSON.stringify([contextActionsBlock]), |
There was a problem hiding this comment.
praise: Thanks for testing the blocks!
There was a problem hiding this comment.
@mwbrooks This was such a good suggestion! I forget why this might've been skipped this in a first pass...
|
@mwbrooks Thank you! I'll merge this now that slackapi/python-slack-sdk#1755 has merged with similar changes and test! 🚢 💨 |
2 participants
Summary
This PR refactors the
@slack/web-apiimplementation of the chat stream helper to match implementation of #2379 for consistent maintenance.Reviewers
No changes to functionalities!
Requirements