feat(web-api): expose public ts property on ChatStream#2611
Open
srtaalej wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 3a3a0d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
==========================================
+ Coverage 88.86% 88.88% +0.02%
==========================================
Files 62 62
Lines 10230 10240 +10
Branches 450 451 +1
==========================================
+ Hits 9091 9102 +11
+ Misses 1117 1116 -1
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a public read-only ts getter to ChatStreamer, enabling users to call chat.update as a fallback when the server closes a stream due to undocumented timeouts.
Background
When Slack's server-side timeout kills a stream, both
chat.appendStreamandchat.stopStreamreturnmessage_not_in_streaming_state. The message still exists but is stuck as a broken pill in the UI. The only recovery path ischat.update({ ts: ... }), buttswas previously a private field (streamTs).Changes
packages/web-api/src/chat-stream.ts: Addedtsgetter (read-only, returnsstring | undefined)packages/web-api/src/WebClient.test.ts: Added test verifyingtsis undefined before flush and set aftercode snippet
Requirements