docs(deps): establish and apply a managing-dependencies convention#1915
Merged
Conversation
Add the managing-dependencies skill documenting the requirements-file layout convention and the PEP 508 python_version marker pattern that keeps one set of pins working across the full Python matrix (3.7-3.14 plus PyPy). Correct the file-scope table: documentation.txt is not installed by any CI job (only the manual docs script), and point the "which files need markers" decision at .github/workflows/ci-build.yml as the source of truth. Route the AGENTS.md Dependencies section to the skill rather than restating its mechanism. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…nvention Apply the one-dependency-per-section layout across all requirements/*.txt files: install header, per-dep name header, and full-line `Note:` rationale comments. Convert trailing inline comments to full-line notes and remove the empty trailing `;` fossils in tools.txt. Refine the skill doc so rationale notes start with `Note:` and its examples match the section layout. No version pins change; this is a formatting/documentation pass only. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
WilliamBergamin
added
the
dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1915 +/- ##
==========================================
- Coverage 84.15% 84.14% -0.01%
==========================================
Files 117 117
Lines 13366 13366
==========================================
- Hits 11248 11247 -1
- Misses 2118 2119 +1 ☔ View full report in Codecov by Harness. |
zimeg
approved these changes
Jul 15, 2026
zimeg
left a comment
zimeg
left a comment
Member
There was a problem hiding this comment.
🐍 @WilliamBergamin Thinking ahead! I like these changes 🎁 ✨
Comment on lines
+32
to
34
| # boto3 | ||
| # Note: used only under slack_sdk/*_store. | ||
| boto3<=2 |
Member
There was a problem hiding this comment.
👁️🗨️ praise: Thanks for formatting dependencies with additional comments to follow!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Establishes a single, self-documenting convention for
requirements/*.txtand applies it repo-wide, so one set of pins keeps working across the whole Python matrix (3.7 → 3.14 + PyPy) and dependency diffs stay readable.Testing
requirements/*.txtand confirm no version constraint changed (only comments/layout).optional.txtuses full-line comments only, since it feeds wheel metadata via[tool.setuptools.dynamic]inpyproject.toml.Category
/docs(Documents)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.🤖 Generated with Claude Code