revert(experiment): separate create questions with flag parsings#401
revert(experiment): separate create questions with flag parsings#401
Conversation
| "context" | ||
| "strings" | ||
|
|
||
| huh "charm.land/huh/v2" |
There was a problem hiding this comment.
🧰 thought: Separating API and prompts from cmd packages might make testing boundaries more concise? We have mock setups to test particular option and flag arguments are provided as a MatchPromptConfig helper, which might lean on tests for existing prompts.
🤓 ramble: In this example, L1357 can also be set with a slice of options to match in the select:
slack-cli/internal/prompts/app_select_test.go
Lines 1353 to 1372 in 35e1743
There was a problem hiding this comment.
👾 ramble: I think boundaries of iostreams might be best instead of prompting imports for huh often!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
==========================================
- Coverage 67.90% 67.82% -0.08%
==========================================
Files 218 217 -1
Lines 18050 17997 -53
==========================================
- Hits 12256 12206 -50
+ Misses 4640 4637 -3
Partials 1154 1154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changelog
Summary
This PR reverts #362 to separate
createquestions with flag parsing handled with theclients.IOpackage. This hopes to fix an issue with the--templateflag.Notes
charmexperiment I'm thinking to cover edge cases of the initialsurveytohuhpackage switch before extending specific promptsRequirements