feat: show confirm prompts as a vertical selection by srtaalej · Pull Request #564 · slackapi/slack-cli

srtaalej · 2026-05-27T21:56:14Z

Changelog

Y/N select prompts now display as vertical selection similar to 'slack create'.

Summary

This PR changes the Y/N select prompt from left/right selector to up/down selector.

When using a Yes/No confirm prompt (huh), the currently selected button is hard to distinguish from the unselected one. The ThemeSurvey theme doesn't override the default huh button styles, so it falls through to ThemeBase defaults.
Depending on terminal theme and background color, these can look very similar or the contrast between them isn't obvious enough to tell which one you're currently on.

Preview

Before

After

Testing

Run slack app delete or any command with a confirm prompt and verify the Yes/No options appear as a vertical list with the chevron selector
Confirm arrow keys (up/down) navigate between Yes and No
Confirm Enter submits the highlighted option
Verify accessible mode still works (--accessible flag shows numbered options)

Notes

Adresses issue #562

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

codecov · 2026-05-27T22:00:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.66%. Comparing base (ae61a10) to head (cedde44).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   71.68%   71.66%   -0.03%     
==========================================
  Files         226      226              
  Lines       19140    19144       +4     
==========================================
- Hits        13721    13719       -2     
- Misses       4214     4216       +2     
- Partials     1205     1209       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zimeg

@srtaalej Super appreciate this change! It makes selections feel more expected 🎨 ✨

I'm a fan of the approach and am leaving a comment before approving after testing this a bit 🔬 Let me know what you think! This is exciting! 🚢

zimeg · 2026-05-28T05:35:23Z


 // confirmForm interactively prompts for a yes/no confirmation.
 func confirmForm(io *IOStreams, _ context.Context, message string, defaultValue bool) (bool, error) {
 	var choice = defaultValue


🌵 question: Is setting the default value to "true" - or the top option - for all confirmation prompts too wild an idea?

🦔 ramble: I found it jarring when testing and think it might be most predictable to prompt from start.

slack-cli/.github/STYLE_GUIDE.md

Lines 16 to 22 in 85f5c96

### Prompts are Flags with Forms

When information is needed we can prompt for text, confirmation, or a selection.

These decisions can be made in an interactive terminal (TTY) or not, such as in a scripting environment.

A flag option should exist for each prompt with a form fallback. Either default values should be used if forms are attempted in a non-TTY setup or an error and remmediation to use a flag should be returned.

🏁 ramble: We ought keep flag defaults as is but also that might bring follow up discussion on flag pairings for various prompts. The force flag is overused and unclear IMHO. For the delete example I'd expected instead:

- --force + --confirm-delete

ahh yes this makes more sense! thank you for sharing that doc 👁️ ❤️

@srtaalej Ah I meant to suggest keeping the ordering as was:

Yes

No

But removing the default value from forms. The latest commit 9a8cbee reversed the ordered but now default values that are "true" will appear on bottom:

$ slack init

zimeg

@srtaalej Was late writing but think we ought still remove default values that aren't starting at the top for forms - I comment an example more 👁️‍🗨️

zimeg · 2026-05-28T23:31:31Z


 // confirmForm interactively prompts for a yes/no confirmation.
 func confirmForm(io *IOStreams, _ context.Context, message string, defaultValue bool) (bool, error) {
 	var choice = defaultValue


@srtaalej Ah I meant to suggest keeping the ordering as was:

Yes

No

But removing the default value from forms. The latest commit 9a8cbee reversed the ordered but now default values that are "true" will appear on bottom:

$ slack init

srtaalej · 2026-05-29T20:35:26Z

 // confirmForm interactively prompts for a yes/no confirmation.
-func confirmForm(io *IOStreams, _ context.Context, message string, defaultValue bool) (bool, error) {
-	var choice = defaultValue
+func confirmForm(io *IOStreams, _ context.Context, message string, _ bool) (bool, error) {


note: defualtValue is unused but I renamed it to _ because it's required by the IOStreams interface signature

@srtaalej IMO we should update the call signature to avoid confusion when passing a value here?

Suggested change

func confirmForm(io *IOStreams, _ context.Context, message string, _ bool) (bool, error) {

func confirmForm(io *IOStreams, _ context.Context, message string) (bool, error) {

👾 ramble: I'm unsure how much change that might cause but I think now'd be the right time to keep updates together!

i actually think that the caller can be updated in a different PR because it touches files outside the scope of this pr 🤔 what do you think

🔭 @srtaalej I'm understanding removing defaults from confirm prompt for vertical selections is a change to those prompts also?

Fair to follow up with removing this because it's internal refactor but current branch has code in odd state without removing these defaults:

slack-cli/cmd/app/delete.go

Line 123 in 4e52cbd

proceed, err := IO.ConfirmPrompt(ctx, "Are you sure you want to delete the app?", false)

slack-cli/cmd/app/link.go

Line 139 in 4e52cbd

proceed, err := clients.IO.ConfirmPrompt(ctx, LinkAppConfirmPromptText, true)

zimeg

@srtaalej Much appreciated to the changes of 199785b but I want to request changes to keep prompts and forms consistent across the interface here. Thanks for calling out this change earlier 👾 ✨

zimeg · 2026-06-01T23:26:36Z

 // confirmForm interactively prompts for a yes/no confirmation.
-func confirmForm(io *IOStreams, _ context.Context, message string, defaultValue bool) (bool, error) {
-	var choice = defaultValue
+func confirmForm(io *IOStreams, _ context.Context, message string, _ bool) (bool, error) {


@srtaalej IMO we should update the call signature to avoid confusion when passing a value here?

Suggested change

func confirmForm(io *IOStreams, _ context.Context, message string, _ bool) (bool, error) {

func confirmForm(io *IOStreams, _ context.Context, message string) (bool, error) {

👾 ramble: I'm unsure how much change that might cause but I think now'd be the right time to keep updates together!

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

This reverts commit 4e52cbd.

mwbrooks

🙇🏻 Thanks for putting together this PR @srtaalej!

🧪 I've left some important feedback around default values. I think we need to address it before we can merge this PR.

We must support default values for the confirmation prompt to avoid regression
The visual order should never change, just the default selected choice

mwbrooks · 2026-06-02T13:53:53Z

 // confirmForm interactively prompts for a yes/no confirmation.
-func confirmForm(io *IOStreams, _ context.Context, message string, defaultValue bool) (bool, error) {
-	var choice = defaultValue
+func confirmForm(io *IOStreams, _ context.Context, message string, _ bool) (bool, error) {


suggestion: @srtaalej I don't think we can ignore the default value (_ bool). Many commands set the default value to false (No) and this is extremely important to avoid destructive behaviour. For example, deleting an app will default to no because we don't want a developer to accidentally, permanently deleting their App ID.

A quick search shows the following commands deliberately passed false to the confirmation prompt:

cmd/app/delete.go:123 - "Are you sure you want to delete the app?"

cmd/app/uninstall.go:117 - "Are you sure you want to uninstall?"

cmd/sandbox/delete.go:87 - "Are you sure you want to delete the sandbox?"

cmd/app/unlink.go:104 - "Are you sure you want to unlink this app?"

cmd/externalauth/remove.go:111+- Remove all tokens

internal/api/app.go:799 - "Cancel the current request…?"

So we'll want a implementation something like:

func confirmForm(io *IOStreams, _ context.Context, message string, defaultValue bool) (bool, error) { var choice = defaultValue err := buildConfirmForm(io, message, &choice).Run() // ... }

Visually, we want to keep the "Yes / No" order unchanged with "Yes" on top. When the default value is false the second option ("No") will automatically be selected.

┃ Do you want to do this? ┃ Yes ┃ ❱ No

thank you for this clarification @mwbrooks! my latest commit reverts the logic back to the initial commit 🫡

This reverts commit 11f086b.

srtaalej

thank you @zimeg and @mwbrooks for kind reviews!
this latest commit keeps the changes that were made in the initial commit. to clarify on the behavior:
the cursor lands on whatever defaultValue is passed by the command in use 🧚 no changes to the logic only the UI 🫡

srtaalej · 2026-06-02T17:06:09Z

 // buildConfirmForm constructs an interactive form for yes/no confirmation prompts.
 func buildConfirmForm(io *IOStreams, message string, choice *bool) *huh.Form {
-	field := huh.NewConfirm().
+	field := huh.NewSelect[bool]().


order is unchanged and the defaultValue the cursor lands on depends on the command 🫡

No

Yes

zimeg

@srtaalej Thank you for working through feedback I shared - let's get this merged with default options to match current patterns. If this feels unexpected in actual use I'm open to revisiting this without fear of breaking form options 🚢 💨

fix: confusing y/n confirm prompt

9ea1dfe

srtaalej added this to the Next Release milestone May 27, 2026

srtaalej self-assigned this May 27, 2026

srtaalej requested a review from a team as a code owner May 27, 2026 21:56

srtaalej added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented enhancement M-T: A feature request for new functionality labels May 27, 2026

srtaalej added the semver:patch Use on pull requests to describe the release version increment label May 28, 2026

zimeg removed the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label May 28, 2026

zimeg changed the title ~~fix: confusing y/n confirm prompt~~ feat: show confirm prompts as a vertical selection May 28, 2026

zimeg reviewed May 28, 2026

View reviewed changes

fix: make default value top option

9a8cbee

zimeg requested changes May 28, 2026

View reviewed changes

srtaalej requested a review from zimeg May 29, 2026 00:39

remove defaultvalue

199785b

srtaalej commented May 29, 2026

View reviewed changes

zimeg requested changes Jun 1, 2026

View reviewed changes

zimeg added the changelog Use on updates to be included in the release notes label Jun 1, 2026

srtaalej and others added 3 commits June 1, 2026 23:14

Update internal/iostreams/forms.go

4e52cbd

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

Revert "Update internal/iostreams/forms.go"

11f086b

This reverts commit 4e52cbd.

Merge branch 'main' into ale-confirm-to-select

bf5e2f3

mwbrooks requested changes Jun 2, 2026

View reviewed changes

srtaalej and others added 3 commits June 2, 2026 11:54

Reapply "Update internal/iostreams/forms.go"

e96f399

This reverts commit 11f086b.

fix: respect defaultValue in confirmForm

3e78f64

Merge branch 'main' into ale-confirm-to-select

cedde44

srtaalej requested review from mwbrooks and zimeg June 2, 2026 17:00

srtaalej commented Jun 2, 2026

View reviewed changes

zimeg approved these changes Jun 2, 2026

View reviewed changes

srtaalej merged commit 9d98828 into main Jun 2, 2026
10 checks passed

srtaalej deleted the ale-confirm-to-select branch June 2, 2026 17:49

	### Prompts are Flags with Forms

	When information is needed we can prompt for text, confirmation, or a selection.

	These decisions can be made in an interactive terminal (TTY) or not, such as in a scripting environment.

	A flag option should exist for each prompt with a form fallback. Either default values should be used if forms are attempted in a non-TTY setup or an error and remmediation to use a flag should be returned.

	func confirmForm(io *IOStreams, _ context.Context, message string, _ bool) (bool, error) {
	func confirmForm(io *IOStreams, _ context.Context, message string) (bool, error) {

Conversation

srtaalej commented May 27, 2026

Changelog

Summary

Preview

Testing

Notes

Requirements

Uh oh!

codecov Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwbrooks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

srtaalej left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented May 27, 2026 •

edited

Loading

srtaalej left a comment •

edited

Loading