Add nolint exclusion on authority.WithProvisioner usage#1589
Merged
Conversation
github-actions
bot
added
the
needs triage
dopey
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undoes the change in #1587.
@dopey not sure what's going on here (yet). After merging #1430 it seems to have failed. It also did in the merge before that. It did not in https://github.com/smallstep/cli/actions/runs/22926902099/job/66539409429, which also uses
v2.10.1. On merging #1587, the regular linting process completed, but when it was triggered after tagging it failed. I've definitely seen this type of flapping before. Some caching going on, and analysis happening on a non-current version of the code, somehow?If anything, the
nolintseems necessary, as I don't see any indication thatstaticcheckwas removed from earlier/later versions. If it flaps again, we maybe can addnolintlintas an exclusion too as a workaround.