Fix pollOneoff#2092
Open
miro-cl wants to merge 3 commits into
Open
Conversation
|
👋 miro-cl, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes pollOneoff event dispatch by ensuring the WASI eventTypeClock constant has the correct value (0), aligning with the WASI preview1 spec.
Changes:
- Split the constant declarations so
iotaforeventType*starts at0. - Preserve existing
subscriptionLen/eventsLenconstants while correcting event type numbering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 API Diff Results
|
This reverts commit e4a4d4f.
nolag
approved these changes
May 26, 2026
russell-stern
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
pollOneoffby correctingeventTypeClockvalue, which should be zero.Requires
Supports