Skip to content

inject CapDonID#2102

Merged
DylanTinianov merged 3 commits into
mainfrom
CRE-4409-capability-don-id
Jun 1, 2026
Merged

inject CapDonID#2102
DylanTinianov merged 3 commits into
mainfrom
CRE-4409-capability-don-id

Conversation

@tarcisiozf
Copy link
Copy Markdown
Contributor

Requires

Supports

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

✅ API Diff Results - github.com/smartcontractkit/chainlink-common

✅ Compatible Changes (3)

pkg/capabilities/pb.(*InitialiseRequest) (1)
  • GetCapabilityDonId — ➕ Added
pkg/capabilities/pb.InitialiseRequest (1)
  • CapabilityDonId — ➕ Added
pkg/types/core.StandardCapabilitiesDependencies (1)
  • CapabilityDonID — ➕ Added

📄 View full apidiff report

@tarcisiozf tarcisiozf force-pushed the CRE-4409-capability-don-id branch from d972907 to 3f2cb4c Compare May 29, 2026 14:37
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: ac26b1a Previous: d972907 Ratio
BenchmarkKeystore_Sign/nop/out-of-process 81179 ns/op 26228 ns/op 3.10
BenchmarkKeystore_Sign/hex/out-of-process 79804 ns/op 26633 ns/op 3.00
BenchmarkKeystore_Sign/ed25519/in-process 29219 ns/op 14070 ns/op 2.08
BenchmarkKeystore_Sign/ed25519/out-of-process 132063 ns/op 46478 ns/op 2.84

This comment was automatically generated by workflow using github-action-benchmark.

Comment thread pkg/types/core/standard_capabilities_dependencies.go
@patrickhuie19 patrickhuie19 requested a review from jmank88 May 29, 2026 17:33
@tarcisiozf tarcisiozf marked this pull request as ready for review June 1, 2026 17:59
Copilot AI review requested due to automatic review settings June 1, 2026 17:59
@tarcisiozf tarcisiozf requested a review from a team as a code owner June 1, 2026 17:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new CapabilityDonID value to the standard capability initialisation dependency set and plumbs it through the loop gRPC Initialise request, allowing plugins to reliably know the on-chain DON ID of the capability DON they’re running under.

Changes:

  • Added CapabilityDonID uint32 to core.StandardCapabilitiesDependencies with documentation describing intended semantics and fallback behavior.
  • Extended capabilities.InitialiseRequest protobuf with capability_don_id and regenerated Go bindings.
  • Wired the new field through the standard capabilities client/server initialisation path.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
pkg/types/core/standard_capabilities_dependencies.go Adds CapabilityDonID to the dependency struct (documented semantics).
pkg/loop/internal/core/services/capability/standard/standard_capabilities.go Passes CapabilityDonID via gRPC request and injects it server-side.
pkg/capabilities/pb/capabilities.proto Adds capability_don_id field to InitialiseRequest.
pkg/capabilities/pb/capabilities.pb.go Regenerated protobuf Go code for the new field/getter.
Files not reviewed (1)
  • pkg/capabilities/pb/capabilities.pb.go: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DylanTinianov DylanTinianov added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit 0b9e934 Jun 1, 2026
32 of 33 checks passed
@DylanTinianov DylanTinianov deleted the CRE-4409-capability-don-id branch June 1, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants