inject CapDonID#2102
Conversation
✅ API Diff Results -
|
d972907 to
3f2cb4c
Compare
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: ac26b1a | Previous: d972907 | Ratio |
|---|---|---|---|
BenchmarkKeystore_Sign/nop/out-of-process |
81179 ns/op |
26228 ns/op |
3.10 |
BenchmarkKeystore_Sign/hex/out-of-process |
79804 ns/op |
26633 ns/op |
3.00 |
BenchmarkKeystore_Sign/ed25519/in-process |
29219 ns/op |
14070 ns/op |
2.08 |
BenchmarkKeystore_Sign/ed25519/out-of-process |
132063 ns/op |
46478 ns/op |
2.84 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Pull request overview
This PR adds a new CapabilityDonID value to the standard capability initialisation dependency set and plumbs it through the loop gRPC Initialise request, allowing plugins to reliably know the on-chain DON ID of the capability DON they’re running under.
Changes:
- Added
CapabilityDonID uint32tocore.StandardCapabilitiesDependencieswith documentation describing intended semantics and fallback behavior. - Extended
capabilities.InitialiseRequestprotobuf withcapability_don_idand regenerated Go bindings. - Wired the new field through the standard capabilities client/server initialisation path.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/types/core/standard_capabilities_dependencies.go | Adds CapabilityDonID to the dependency struct (documented semantics). |
| pkg/loop/internal/core/services/capability/standard/standard_capabilities.go | Passes CapabilityDonID via gRPC request and injects it server-side. |
| pkg/capabilities/pb/capabilities.proto | Adds capability_don_id field to InitialiseRequest. |
| pkg/capabilities/pb/capabilities.pb.go | Regenerated protobuf Go code for the new field/getter. |
Files not reviewed (1)
- pkg/capabilities/pb/capabilities.pb.go: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Requires
Supports