comment out test code that sometimes fails and is not used anyway#21874
Merged
comment out test code that sometimes fails and is not used anyway#21874
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
product-security-plaid-production
bot
requested review from
Atrax1 and
simsonraj
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW — change is confined to a system smoke test and removes a flaky/unused DB stats snapshot.
This PR reduces flakiness in the EVM LogTrigger smoke test by commenting out trigger DB baseline/stat snapshot code that was only relevant to a currently-disabled ACK verification path.
Changes:
- Comment out
connectTriggerDBusage andsnapshotTriggerStatsbaseline collection inExecuteEVMLogTriggerTest. - Add a TODO marker referencing CRE-2314 for re-enabling trigger event ACK checks.
|
mchain0
reviewed
Apr 7, 2026
mchain0
approved these changes
Apr 7, 2026
skudasov
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
that baseline was used by assertion that was commented out and I saw it failing some tests, so I think it's best to comment it out too.