Conversation
product-security-plaid-production
Bot
requested review from
ecPablo,
erikburt,
ilija42 and
pavel-raykov
|
👋 kalverra, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Fixes flakiness in Test_Service_syncNodeInfoWithRetry/update_chain by filtering observed log messages to only those emitted by syncNodeInfoWithRetry (excluding unrelated noise from other goroutines) and increasing the eventual-assertion timeout. Also adds minor documentation updates to the fix-flaky-tests skill.
Changes:
- Add
syncNodeInfoLogMessages/filterSyncNodeInfoLogMessageshelpers and switch the flaky test to use them with a longer (5s) timeout and tighter (5ms) poll interval. - Add unit tests for the new log-filtering helpers in a new
log_messages_test.go. - Document a diagnose iteration table and tighten Jira reference STOP conditions in the
fix-flaky-testsskill.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/services/feeds/service_test.go | Filter logs to sync-node-info entries and bump timeout to stabilize test |
| core/services/feeds/log_messages_test.go | New unit tests for the log filter helpers |
| tools/test/.agents/skills/fix-flaky-tests/SKILL.md | Add iteration-vs-flake-probability reference table |
| tools/test/.agents/skills/fix-flaky-tests/references/jira.md | Clarify Atlassian MCP availability/authentication STOP conditions |
kalverra
changed the title
|
Used the
fix-flaky-testsskill to fix DX-4303.