Vault: automated stale pending queue purge#22689
Draft
russell-stern wants to merge 3 commits into
Draft
Conversation
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Summary
Adds a gated recovery path when the vault KV pending queue is stuck and blocking observation quorum, so ops no longer need to leave
VaultForceEmptyOCRRoundsenabled globally.Depends on chainlink-common#2104 (
StoredPendingQueueIndex.written_seq_nr, CRE settingsVaultPendingQueueStaleAutoEmptyandVaultPendingQueueStaleRoundThreshold).Stale pending queue auto-empty (gated, default off)
VaultPendingQueueStaleAutoEmptyis on andseqNr - written_seq_nr >= VaultPendingQueueStaleRoundThreshold(default 30),ObservationandValidateObservationskip store-backed pending items for that round—same effect as force-empty for the KV queue only, so a successfulStateTransitioncan rewrite/clear stuck entries.written_seq_nris written to the pending queue index only when the gate is enabled, keeping KV index bytes identical to pre-change{length}serialization while the feature is off (avoids rollout / determinism issues).written_seq_nr == 0, auto-empty does not run until the first post-enableWritePendingQueuesets the watermark.VaultForceEmptyOCRRoundsis unchanged and still takes precedence when enabled (manual escape hatch).Local queue hardening (ungated)
prepareObservationPendingQueueBlobsskips a single oversize local-queue blob instead of failing the whole observation.Observability