Skip to content

Add graceful fallback to identical response validation when more than F+1 matching responses required#23220

Open
amit-momin wants to merge 2 commits into
developfrom
cre/graceful-fallback-identical-response-validation
Open

Add graceful fallback to identical response validation when more than F+1 matching responses required#23220
amit-momin wants to merge 2 commits into
developfrom
cre/graceful-fallback-identical-response-validation

Conversation

@amit-momin

Copy link
Copy Markdown
Contributor

No description provided.

…figured to require more than F+1 matching responses
@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Jul 23, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestConfigPoller/LatestConfig,_when_logs_have_been_pruned_and_config_store_contract_is_configured The test failed during the configuration poller test related to log pruning and config store contract. Logs ↗︎
TestConfigPoller/LatestConfig,_when_logs_have_been_pruned_and_config_store_contract_is_configured/if_callReadConfig_succeeds/when_con... The test failed due to mismatched expected and actual values in configuration data, indicating a discrepancy in the configuration retrieval or setup. Logs ↗︎
TestConfigPoller/LatestConfig,_when_logs_have_been_pruned_and_config_store_contract_is_configured/if_callReadConfig_succeeds The test failed during the execution of a specific configuration poller test case, but the exact cause of failure is not provided. Logs ↗︎

View Full Report ↗︎Docs

@cl-sonarqube-production

Copy link
Copy Markdown

@amit-momin
amit-momin marked this pull request as ready for review July 23, 2026 19:56
@amit-momin
amit-momin requested review from a team as code owners July 23, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant