Update closure types example - #1311
Open
JordonPhillips wants to merge 2 commits into
Open
Conversation
JordonPhillips
force-pushed
the
JordonPhillips/blog-example
branch
3 times, most recently
from
August 10, 2026 13:22
fada18a to
8e05bb6
Compare
joewyz
reviewed
Aug 11, 2026
This updates the closure types example to show not only combined mode, but also types only and no types. Having every type in one example is useful to show how the same model may be used in multiple ways. This example will be referenced in a blog post announcing closure-based codegen, so keeping it all in one is particularly important.
JordonPhillips
force-pushed
the
JordonPhillips/blog-example
branch
from
August 12, 2026 13:35
8e05bb6 to
bbbbe55
Compare
joewyz
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
Describe the observable difference in behavior before and after this change.
This updates the closure types example to show not only combined mode, but also types only and no types. Having every type in one example is useful to show how the same model may be used in multiple ways. This example will be referenced in a blog post announcing closure-based codegen, so keeping it all in one is particularly important.
Why is this change needed?
Explain the motivation: bug, feature request, refactor, performance, etc.
It showcases the feature more broadly. And conforms to what I want to discuss in a blog post discussing the feature.
How was this validated?
List tests added, benchmarks run, or manual verification performed.
There's tests. Even tests covering example code, to an extent.
What should reviewers focus on?
Point reviewers to the files or sections that contain the interesting logic.
Focus on the model and the readme.
Additional Links
Related issues, design docs, or prior art.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.