fix: quote recursive union member annotations

[Alan4506]

Description of changes:

Generating a client from a model that contains a recursive union currently fails the code generation process. For example, DynamoDB's AttributeValue is a union where the M variant targets a map of AttributeValue and the L variant targets a list of AttributeValue. These generate Python members typed dict[str, AttributeValue] and list[AttributeValue], i.e. they reference the union itself. smithy build --aut fails during ruff check --fix with:

models.py:15921:22: F821 Undefined name `AttributeValue`
models.py:15941:17: F821 Undefined name `AttributeValue`

The reason is that the AttributeValue union alias is emitted after its member dataclasses, so a member annotation like value: dict[str, AttributeValue] is a forward reference to a name that isn't defined yet.

StructureGenerator already handles this: when a member targets a recursive shape, it wraps the type annotation in quotes to make it a forward reference. UnionGenerator is passed the same set of recursive shapes but never uses it, so union members miss this treatment. This change applies the same logic in UnionGenerator. Only members whose target is a recursive shape are affected; all other unions generate exactly as before.

Testing:

Validated against the DynamoDB model which failed the code generation before. Locally, on top of the clean-json-rpc-v1 branch (which adds AWS JSON protocol support), I applied this change together with #707 (strip \^ escape in docstrings). With both changes in place, the DynamoDB client generates successfully: smithy build --aut passes ruff and pyright cleanly, and there are no F821 errors.

Inspecting the generated AttributeValue union members confirms the recursive annotations are now quoted:

# Before
value: dict[str, AttributeValue]
value: list[AttributeValue]

# After
value: "dict[str, AttributeValue]"
value: "list[AttributeValue]"

(The code emits single quotes, matching StructureGenerator; ruff format then normalizes them to double quotes, which is what appears in the generated output.)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[alexgromero]

Thanks @Alan4506! Nice fix.

One thought before merge: could we add a small recursive union to the integ test model in codegen/core/src/it/resources/META-INF/smithy/main.smithy? I tried it locally and the :core:integ test fails with the same F821 error. On this branch it passes. That way we'd catch regressions.

Something like:

// In operation ListCities output, after `mutual: MutuallyRecursiveA`:
recursiveUnion: RecursiveUnion

// After structure MutuallyRecursiveB:
union RecursiveUnion {
    nested: RecursiveUnionMap
    items: RecursiveUnionList
    leaf: String
}

map RecursiveUnionMap {
    key: String
    value: RecursiveUnion
}

list RecursiveUnionList {
    member: RecursiveUnion
}

[Alan4506]

Thanks @Alan4506! Nice fix.

One thought before merge: could we add a small recursive union to the integ test model in codegen/core/src/it/resources/META-INF/smithy/main.smithy? I tried it locally and the :core:integ test fails with the same F821 error. On this branch it passes. That way we'd catch regressions.

Something like:

// In operation ListCities output, after `mutual: MutuallyRecursiveA`:
recursiveUnion: RecursiveUnion

// After structure MutuallyRecursiveB:
union RecursiveUnion {
    nested: RecursiveUnionMap
    items: RecursiveUnionList
    leaf: String
}

map RecursiveUnionMap {
    key: String
    value: RecursiveUnion
}

list RecursiveUnionList {
    member: RecursiveUnion
}

Thanks @alexgromero ! Addressed in 8f62eeb and verified :core:integ passed.

[alexgromero]