fix: handle URIs with encoded spaces in applyEdit [IDE-1555] #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace VirtualFileManager.findFileByUrl() with toVirtualFileOrNull() which properly decodes URL-encoded characters (e.g., %20 to spaces) - Add debug logging to applyEdit and DocumentChanger to trace URI handling - Fixes issue where applyEdit failed for paths containing spaces, dots, and underscores The issue was that findFileByUrl() doesn't handle URL-encoded URIs. Using toVirtualFileOrNull() converts the URI to a path first, which automatically decodes %20 to spaces, then finds the file using the decoded path.
|
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
andrewrobinsonhodges-snyk
approved these changes
Dec 5, 2025
acke
force-pushed
the
fix/IDE-1555_Agent-Fix-Apply-Fix-Not-Working
branch
from
b812b98 to
e3805f3
Compare
Replace Logger.getInstance() with logger<DocumentChanger>() to match the pattern used throughout the codebase
acke
force-pushed
the
fix/IDE-1555_Agent-Fix-Apply-Fix-Not-Working
branch
from
e3805f3 to
e1c8ee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that findFileByUrl() doesn't handle URL-encoded URIs. Using toVirtualFileOrNull() converts the URI to a path first, which automatically decodes %20 to spaces, then finds the file using the decoded path.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!