Skip to content

Run tests on Windows.#184

Draft
ioquatix wants to merge 3 commits into
mainfrom
windows-support
Draft

Run tests on Windows.#184
ioquatix wants to merge 3 commits into
mainfrom
windows-support

Conversation

@ioquatix

@ioquatix ioquatix commented Oct 13, 2022

Copy link
Copy Markdown
Member

This is an experimental PR to see how badly Windows fails.

Types of Changes

  • New feature.

Testing

  • I added tests for my changes.
  • I tested my changes locally.
  • I tested my changes in staging.
  • I tested my changes in production.

@ioquatix

ioquatix commented Dec 6, 2022

Copy link
Copy Markdown
Member Author
101 passed 1 failed 118 errored out of 220 total (257 assertions)

@ioquatix

ioquatix commented Dec 6, 2022

Copy link
Copy Markdown
Member Author

@larskanis not sure if you are interested to help on this, but the recent changes for UNIXSocket have made this easier.

@larskanis

Copy link
Copy Markdown

@ioquatix I made some small changes and it seems to work.

@ioquatix

ioquatix commented Dec 7, 2022

Copy link
Copy Markdown
Member Author

@larskanis should we make IO on windows non-blocking by default where possible? It's already the default on Linux.

@ioquatix

ioquatix commented Dec 7, 2022

Copy link
Copy Markdown
Member Author

ruby/ruby#6874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants