Conversation
|
pkg.pr.new packages benchmark commit |
8e7e2c6 to
582630b
Compare
aleksanderkatan
left a comment
There was a problem hiding this comment.
Nice!
Do we plan on keeping these examples as dev only?
There was a problem hiding this comment.
Yeah, I know about these issues. I have this new PR open which rewrites the implementation, then I'll think about what to do in these specific cases. It is not completely obvious to me what strategy is visually best yet.
There was a problem hiding this comment.
oh wait, this exact issue I have not seen before. But maybe look at the new implementation PR and see if you can rebase your changes. I have already aligned (all?) the implementations with recent main.
There was a problem hiding this comment.
I had another look, and indeed this happens when you try using "arrow" caps. They are kinda fiddly in terms of cases where they work nicely. When there is such a short and thick segment, the arrow is way bigger than it, causing the issue you are seeing. So in this case, yes it is expected.
Yes, until we publish the @typegpu/geometry package. |
|
@cieplypolar Please let me know if there are more things to align in #1935, otherwise we can close this one. EDIT: didn't realize there were tests. I will move them over to the other PR. |

Closes #1930.