Skip to content

WIP fix: Align @geometry with main#1932

Closed
cieplypolar wants to merge 6 commits intomainfrom
fix/broken-examples
Closed

WIP fix: Align @geometry with main#1932
cieplypolar wants to merge 6 commits intomainfrom
fix/broken-examples

Conversation

@cieplypolar
Copy link
Copy Markdown
Collaborator

@cieplypolar cieplypolar commented Nov 21, 2025

  • wgsl resolution test for lines combinations example (tricky, because there are a lot of options)

Closes #1930.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 21, 2025

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@582630b4069c4b7d3b05d6148aac3876728dfed0
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/noise@582630b4069c4b7d3b05d6148aac3876728dfed0
https://pkg.pr.new/software-mansion/TypeGPU/unplugin-typegpu@582630b4069c4b7d3b05d6148aac3876728dfed0

benchmark
view benchmark

commit
view commit

Comment thread packages/typegpu-geometry/src/circle.ts Outdated
@cieplypolar cieplypolar marked this pull request as ready for review November 25, 2025 16:03
Copy link
Copy Markdown
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Do we plan on keeping these examples as dev only?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look intended, did it look like this before the example stopped working?

image

Also, the last two test cases disappear when the segment becomes too short.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know about these issues. I have this new PR open which rewrites the implementation, then I'll think about what to do in these specific cases. It is not completely obvious to me what strategy is visually best yet.

Copy link
Copy Markdown
Contributor

@deluksic deluksic Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait, this exact issue I have not seen before. But maybe look at the new implementation PR and see if you can rebase your changes. I have already aligned (all?) the implementations with recent main.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had another look, and indeed this happens when you try using "arrow" caps. They are kinda fiddly in terms of cases where they work nicely. When there is such a short and thick segment, the arrow is way bigger than it, causing the issue you are seeing. So in this case, yes it is expected.

@iwoplaza
Copy link
Copy Markdown
Collaborator

Do we plan on keeping these examples as dev only?

Yes, until we publish the @typegpu/geometry package.

@cieplypolar cieplypolar changed the title fix: Align @geometry with main WIP fix: Align @geometry with main Dec 10, 2025
@cieplypolar cieplypolar marked this pull request as draft December 10, 2025 22:50
@deluksic
Copy link
Copy Markdown
Contributor

deluksic commented Mar 12, 2026

@cieplypolar Please let me know if there are more things to align in #1935, otherwise we can close this one.

EDIT: didn't realize there were tests. I will move them over to the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Fix 'Lines Combinations' and 'Wind Map' examples

4 participants