fix(v2): Vite 8 compatible manifest plugin#2080
fix(v2): Vite 8 compatible manifest plugin#2080birkskyum wants to merge 16 commits intosolidjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 65448a9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for solid-start-landing-page failed. Why did it fail? →
|
commit: |
98d0ca2 to
02eb822
Compare
|
when still using vite 7 and this pr, size gets larger 😢 @solidjs/start@alpha: 103.4 kb |
Ugh, that are some rough numbers - considering build size is a key selling point of SolidStart. I have an open ticket on vite 8 already regarding solid jsx dependency scanning - so it would be good if someone else could champion the build size related issues. |
|
I think that maybe the increase in build size didn't come from this PR, but rather from: |
Moving to vite 8 w/ rolldown removes an entire category of dev/prod differences with vite 7 having esbuild (dev) + rollup (prod).
Towards
This PR contains:
solid-start:manifest-pluginto correctly resolve the client manifest during SSR builds under Vite 8 / Rolldown. It automatically detects the current major Vite version, and then:.vite/manifest.jsondirectly from theglobalThis.START_CLIENT_BUNDLEmemory footprint like before..solid-start/client/.vite/manifest.jsonfrom the filesystem, solvingundefined 'source'TypeErrors caused by changes to Rolldown'sgenerateBundleasset handling.