Skip to content

fix(v2): Vite 8 compatible manifest plugin#2080

Open
birkskyum wants to merge 16 commits intosolidjs:mainfrom
birkskyum:vite-8-compat
Open

fix(v2): Vite 8 compatible manifest plugin#2080
birkskyum wants to merge 16 commits intosolidjs:mainfrom
birkskyum:vite-8-compat

Conversation

@birkskyum
Copy link
Copy Markdown
Member

@birkskyum birkskyum commented Feb 22, 2026

Moving to vite 8 w/ rolldown removes an entire category of dev/prod differences with vite 7 having esbuild (dev) + rollup (prod).

Towards

This PR contains:

  • Vite 8 & Rolldown Support: Updated the solid-start:manifest-plugin to correctly resolve the client manifest during SSR builds under Vite 8 / Rolldown. It automatically detects the current major Vite version, and then:
    • For Vite 7: Continues to extract the .vite/manifest.json directly from the globalThis.START_CLIENT_BUNDLE memory footprint like before.
    • For Vite 8+: Falls back to reading the fully generated .solid-start/client/.vite/manifest.json from the filesystem, solving undefined 'source' TypeErrors caused by changes to Rolldown's generateBundle asset handling.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 22, 2026

🦋 Changeset detected

Latest commit: 65448a9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 22, 2026

Deploy Preview for solid-start-landing-page failed. Why did it fail? →

Name Link
🔨 Latest commit 65448a9
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/69c8078e429d0900089e5f72

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 22, 2026

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2080
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2080

commit: 65448a9

@birkskyum birkskyum changed the title Vite 8 compat feat: Vite 8 compat Feb 22, 2026
@birkskyum birkskyum changed the title feat: Vite 8 compat fix: Vite 8 compat manifest plugin Feb 22, 2026
@birkskyum birkskyum changed the title fix: Vite 8 compat manifest plugin fix: Vite 8 compatible manifest plugin Feb 22, 2026
@birkskyum birkskyum changed the title fix: Vite 8 compatible manifest plugin fix(v2): Vite 8 compatible manifest plugin Feb 23, 2026
@birkskyum birkskyum added enhancement New feature or request 2.x targeting SolidStart 2.x versions labels Feb 28, 2026
@birkskyum birkskyum marked this pull request as draft March 16, 2026 14:48
@birkskyum birkskyum marked this pull request as ready for review March 17, 2026 00:15
@huseeiin
Copy link
Copy Markdown
Contributor

when still using vite 7 and this pr, size gets larger 😢

@solidjs/start@alpha: 103.4 kb
pr: 115.5 kb

@birkskyum
Copy link
Copy Markdown
Member Author

when still using vite 7 and this pr, size gets larger 😢

@solidjs/start@alpha: 103.4 kb
pr: 115.5 kb

Ugh, that are some rough numbers - considering build size is a key selling point of SolidStart.

I have an open ticket on vite 8 already regarding solid jsx dependency scanning - so it would be good if someone else could champion the build size related issues.

@birkskyum birkskyum marked this pull request as draft March 28, 2026 17:48
@birkskyum birkskyum closed this Mar 28, 2026
@birkskyum birkskyum reopened this Mar 28, 2026
@birkskyum birkskyum marked this pull request as ready for review March 28, 2026 21:15
@birkskyum
Copy link
Copy Markdown
Member Author

birkskyum commented Mar 28, 2026

I think that maybe the increase in build size didn't come from this PR, but rather from:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.x targeting SolidStart 2.x versions enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants