Fix createResource initial value inference#2696
Merged
ryansolid merged 2 commits intoMay 15, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 4b1919a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
le0-0
reviewed
May 14, 2026
| */ | ||
| export function createResource<T, R = unknown>( | ||
| fetcher: ResourceFetcher<true, T, R>, | ||
| options: InitializedResourceOptions<NoInfer<T>, true> |
There was a problem hiding this comment.
Could the problem be resolved by just removing the NoInfer of the T in the InitializedResourceOptions here? In that way, what goes on inside there can contribute to the type T. This would be cleaner than the parallel I mechanism if it works.
Update the initial value inference for createResource.
Member
|
Thanks. I also tried the NoInfer approach but it had holes. Atleast what I tried. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used AI to change the types for
createResourceto close #2676Not 100% sure how well the tests cover type regressions but the new test passes