fix(repo): patch npm-run-all to detect cjs npm exec paths#2810
fix(repo): patch npm-run-all to detect cjs npm exec paths#2810better-salmon wants to merge 1 commit into
Conversation
pnpm 11 exposes npm_execpath as pnpm.cjs, but npm-run-all only treated .js/.mjs paths as Node shims. It tried to execute pnpm.cjs directly and hit EACCES, so the patch treats .cjs as a JS shim and runs it through node.
|
|
Thanks for the report and the patch — the diagnosis is right. Rather than carrying a patch for |
The original is unmaintained and mishandles .cjs npm_execpath values (pnpm under some setups), causing EACCES. The maintained fork ships the same CLI bins with the .cjs handling and other pnpm fixes built in. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Yeah, this is better! I was a little afraid to update a dependency as my first contribution, so I tried to keep the patch minimal and easy to reason about. |
Summary
pnpmmanaged byvite-pluscauses this error:In this particular setup
pnpm 11exposesnpm_execpathaspnpm.cjs. Butnpm-run-allonly treated.js/.mjspaths as Node shims. It tried to executepnpm.cjsdirectly and hitEACCES, so the patch treats.cjsas a JS shim and runs it throughnode.Updating
pnpmto 11.9.0 did not help.How did you test this change?
pnpm buildnow works. The patch is minimal and sufficient.